Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios deeplinks problems #29

Open
fehmidevoteam opened this issue Oct 3, 2023 · 0 comments
Open

ios deeplinks problems #29

fehmidevoteam opened this issue Oct 3, 2023 · 0 comments

Comments

@fehmidevoteam
Copy link

fehmidevoteam commented Oct 3, 2023

i think in place of returning false if options doesn't have this propriété UIApplication.OpenURLOptionsKey.sourceApplication you should return super.application(app, open: url, options: options) to not impact others custom url schemes :

old implémentation

override func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {    
guard let sourceApplication = options[UIApplication.OpenURLOptionsKey.sourceApplication] as? String else {
    return false
}  
return MSALPublicClientApplication.handleMSALResponse(url, sourceApplication: sourceApplication)
}

new one

override func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {    
guard let sourceApplication = options[UIApplication.OpenURLOptionsKey.sourceApplication] as? String else {
    return super.application(app, open: url, options: options)
}  
return MSALPublicClientApplication.handleMSALResponse(url, sourceApplication: sourceApplication)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant