Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling Mudlet directly in Qt-Creator doesn't work anymore #4726

Closed
Edru2 opened this issue Jan 31, 2021 · 6 comments
Closed

Compiling Mudlet directly in Qt-Creator doesn't work anymore #4726

Edru2 opened this issue Jan 31, 2021 · 6 comments

Comments

@Edru2
Copy link
Member

Edru2 commented Jan 31, 2021

Brief summary of issue / Description of requested feature:

see Title

Steps to reproduce the issue / Reasons for adding feature:

  1. Try to build Mudlet directly in Qt-Creator
  2. Several errors about keychain_unix.cpp
  3. Build not succesful

Error output / Expected result of feature

It should build succesfully.

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Os: Ubuntu 20.10
Version: latest code from development branch (31 Jan 2020)

After some discussion with Vadi on discord he found out that the f284aaf is responsible for the issue.

A workaround is to open the project using CMakeLists.txt instead of mudlet.pro

@SlySven
Copy link
Member

SlySven commented Feb 1, 2021

If your OS (Linux / FreeBSD) has the package/library available as a package that you can install you might get by if you define the environmental variable WITH_OWN_QTKEYCHAIN=NO so that Mudlet links to and uses the OSes copy rather than trying to build it itself...

@SlySven
Copy link
Member

SlySven commented Feb 1, 2021

Doing a sortof git bisect on the submodule to see where it breaks things for us...

@SlySven
Copy link
Member

SlySven commented Feb 1, 2021

This seems to have gotten broken at: frankosterfeld/qtkeychain@cbc626e - I have raised this upstream as frankosterfeld/qtkeychain#182 .

@Kebap
Copy link
Contributor

Kebap commented Feb 4, 2021

Upstream issue was fixed meanwhile.
Do we notice any change here, too?

@vadi2
Copy link
Member

vadi2 commented Feb 4, 2021

Haven't merged the change yet - I've merged it into https://github.com/Mudlet/qtkeychain, and dependabot will submit an update for development in it's Friday run.

@vadi2
Copy link
Member

vadi2 commented Feb 5, 2021

Fixed with #4750, thanks for the investigation everyone :)

@vadi2 vadi2 closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants