-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use find (ctrl-f) in a bigger script hangs Mudlet #3846
Comments
Good find on the issue! Using on enter is one way to solve it - although you can also still make it work without the extra key using a technique called "debounce". Basically, setup a timer after every time a key is pressed for say 300ms (killing any old timer), and only when the times runs out, do a search. That way it won't search for every letter but only when you finish typing. |
Comparing browsers or IDE etc. most search without additional enter, but probably some 0.1 seconds delay after last keystroke or alike. |
High priority as Mudlet should be all about performance, not hanging. |
Yes, that's true, after copying the script into vscode I noticed that it works like that, (maybe the comparison is unfair) but in vscode I didn't notice the slightest delay as Mudlet hangs for about a minute before it's usable again. |
The issue is in edbee trying to highlight so many things. See the linked PR for an workaround, and I've asked edbee in edbee/edbee-lib#99 whenever we can do things better. |
Brief summary of issue / Description of requested feature:
If I use the new find function (ctrl-f) in a bigger script, it hangs Mudlet.
I suspect that this happens because the search is already happening during typing,
if I copy paste something I want to find into the search bar it doesn't happen.
Steps to reproduce the issue / Reasons for adding feature:
Error output / Expected result of feature
Mudlet shouldn't hang
Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:
Mudlet 4.8.2
Ubuntu 20.04
Probably it shouldn't start to find results immediately when I start typing but only after pressing enter.
The text was updated successfully, but these errors were encountered: