Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger patterns take up too much space in Mudlet 3.20 #2548

Closed
Eraene opened this issue May 13, 2019 · 6 comments
Closed

Trigger patterns take up too much space in Mudlet 3.20 #2548

Eraene opened this issue May 13, 2019 · 6 comments

Comments

@Eraene
Copy link
Contributor

Eraene commented May 13, 2019

Brief summary of issue / Description of requested feature:

The new feature of allowing the space displaying trigger patterns is a great one, however the default minimum size of displaying 13-15 pattern lines is way, way too much. A minimum of 5-7 patterns displayed would be much, much easier to work with. As it currently stands, it restricts the coding space far too much for it to be comfortable.

Steps to reproduce the issue / Reasons for adding feature:

  1. Current pattern space is way too large for a comfortable working environment.
  2. Because I value my sanity.
  3. Because how many trigger patterns do you really want to see for 90% of triggers?

Error output / Expected result of feature

New working space would be resizable to show minimum of 5-7 pattern lines.

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Windows 10 Home, Mudlet 3.20.1

@Nyyrazzilyss
Copy link
Contributor

I'd be happier myself with the minimum at one line. Was there any reason it had to be a much higher number showing as a minimum?

@Eraene
Copy link
Contributor Author

Eraene commented May 13, 2019

I believe sizing it too small would not be possible due to the complications it would cause with the sound and fire length trigger options, but perhaps with the option to collapse those extra options areas, allowances could be made? I'm not sure, but I would definitely be fine with it being resizable to one pattern, if it were possible to.

@SlySven
Copy link
Member

SlySven commented May 16, 2019

The design was intended so that the controls to the right of the trigger items would disappear at the point when the splitter would just about to start encroaching on the minimum space that they needed.

However users of ultra-high resolution (macOS retina, or so-called 4K) displays are reporting that things are not working like that for them - because they are seeing a lot of trigger item lines. Would you say that was the case for you @Eraene ?

FTR After moving the splitter the control to show/hide those controls should be capable of overriding the result the size of the splitter is causing - and IIRC the show/hide action will only happen again if the splitter is moved...

@vadi2
Copy link
Member

vadi2 commented May 16, 2019

It's the same thing I mentioned - the new default for how many trigger lines are visible is too much. The old default of 5ish seems to have worked well.

@Eraene
Copy link
Contributor Author

Eraene commented May 22, 2019

@SlySven
I'm seeing two separate issues. As Vadi said, the new default for displaying trigger lines is too much.
The second is that if I click the button to hide the trigger controls and then touch the splitter, the controls are brought back again. I don't understand why this is necessary, if I just want to use the splitter to change how many lines are displayed. If I hide the controls, that means I don't want to see them because I don't need them. I should then be able to move the splitter into the space those controls would normally occupy if I want, but clicking to bring back the controls would automatically move the splitter out of the occupied space. Would that work?

For reference, take a look at this editor window. It's resized to the smallest size possible. The space trigger lines take up (along with the vertical splitter's left side minimum) is loads of wasted space, IMO.
image

SlySven added a commit to SlySven/Mudlet that referenced this issue May 25, 2019
This attempts to make the code that shows/hides the controls to the right
and bottom of the triggers_main_area form/dialog not depend on hard coded
settings but rather on the actual space that various widgets claim they
need to be shown correctly (and not to show them if there is not enough).

This should help to address: Mudlet#2548 .

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven added a commit to SlySven/Mudlet that referenced this issue May 25, 2019
This attempts to make the code that shows/hides the controls to the right
and bottom of the triggers_main_area form/dialog not depend on hard coded
settings but rather on the actual space that various widgets claim they
need to be shown correctly (and not to show them if there is not enough).

This should help to address: Mudlet#2548 .

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@SlySven
Copy link
Member

SlySven commented May 29, 2019

I think I am close to nailing the vertical splitter on the right hand side spacing issues now - just want to test on one more OS platform locally (32-bit Windoze 7). Will review what is happening to the left hand side with the horizontal splitter afterwards.

vadi2 pushed a commit that referenced this issue Jun 3, 2019
#2571)

* Refactor: improve handling of show/hiding some trigger editor controls

This attempts to make the code that shows/hides the controls to the right
and bottom of the triggers_main_area form/dialog not depend on hard coded
settings but rather on the actual space that various widgets claim they
need to be shown correctly (and not to show them if there is not enough).

This should help to address: #2548 .

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

* Revise: reduce minimum number of trigger item lines in Editor

This should force the minimum to be around one and a half lines for all
Operating Systems and Desktop Environments.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

* Revise: try an alternative means to see if all the trigger controls fit

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

* Revise: further tweak to ensure widgets get hidden when there is no space

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@vadi2 vadi2 closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants