-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger patterns take up too much space in Mudlet 3.20 #2548
Comments
I'd be happier myself with the minimum at one line. Was there any reason it had to be a much higher number showing as a minimum? |
I believe sizing it too small would not be possible due to the complications it would cause with the sound and fire length trigger options, but perhaps with the option to collapse those extra options areas, allowances could be made? I'm not sure, but I would definitely be fine with it being resizable to one pattern, if it were possible to. |
The design was intended so that the controls to the right of the trigger items would disappear at the point when the splitter would just about to start encroaching on the minimum space that they needed. However users of ultra-high resolution (macOS retina, or so-called 4K) displays are reporting that things are not working like that for them - because they are seeing a lot of trigger item lines. Would you say that was the case for you @Eraene ? FTR After moving the splitter the control to show/hide those controls should be capable of overriding the result the size of the splitter is causing - and IIRC the show/hide action will only happen again if the splitter is moved... |
It's the same thing I mentioned - the new default for how many trigger lines are visible is too much. The old default of 5ish seems to have worked well. |
@SlySven For reference, take a look at this editor window. It's resized to the smallest size possible. The space trigger lines take up (along with the vertical splitter's left side minimum) is loads of wasted space, IMO. |
This attempts to make the code that shows/hides the controls to the right and bottom of the triggers_main_area form/dialog not depend on hard coded settings but rather on the actual space that various widgets claim they need to be shown correctly (and not to show them if there is not enough). This should help to address: Mudlet#2548 . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This attempts to make the code that shows/hides the controls to the right and bottom of the triggers_main_area form/dialog not depend on hard coded settings but rather on the actual space that various widgets claim they need to be shown correctly (and not to show them if there is not enough). This should help to address: Mudlet#2548 . Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
I think I am close to nailing the vertical splitter on the right hand side spacing issues now - just want to test on one more OS platform locally (32-bit Windoze 7). Will review what is happening to the left hand side with the horizontal splitter afterwards. |
#2571) * Refactor: improve handling of show/hiding some trigger editor controls This attempts to make the code that shows/hides the controls to the right and bottom of the triggers_main_area form/dialog not depend on hard coded settings but rather on the actual space that various widgets claim they need to be shown correctly (and not to show them if there is not enough). This should help to address: #2548 . Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: reduce minimum number of trigger item lines in Editor This should force the minimum to be around one and a half lines for all Operating Systems and Desktop Environments. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: try an alternative means to see if all the trigger controls fit Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: further tweak to ensure widgets get hidden when there is no space Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Brief summary of issue / Description of requested feature:
The new feature of allowing the space displaying trigger patterns is a great one, however the default minimum size of displaying 13-15 pattern lines is way, way too much. A minimum of 5-7 patterns displayed would be much, much easier to work with. As it currently stands, it restricts the coding space far too much for it to be comfortable.
Steps to reproduce the issue / Reasons for adding feature:
Error output / Expected result of feature
New working space would be resizable to show minimum of 5-7 pattern lines.
Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:
Windows 10 Home, Mudlet 3.20.1
The text was updated successfully, but these errors were encountered: