Package manager should report results

[zesstra]

Imported package does not show up in Scripts:

Steps to reproduce the issue / Reasons for adding feature:

1. Create new empty profile (don't know if that is important)
2. Import .xml within Package Manage, e.g. https://github.com/Mundron/ASCII-Mapper-2.0/blob/master/ASCIIMapper_Mundron.xml or https://github.com/krrrcks/krrrcks-mudlet/blob/master/krrrcks.xml
3. Package shows up in Package Manager, but not in Scripts

Error output / Expected result of feature

Imported scripts shown in Scripts window / group

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Mudlet 3.17.0 for MacOS (10.13.6).

[Kebap]

Tested same links on Windows. Scripts show up in Package Manager as well as in Scripts like they should do. Could not test on Mac myself. Maybe there is a problem only on some OS, but not for me currently.

[SlySven]

I was going to say I can reproduce this on GNU/Linux as well, the packages are shown in the Package Manager dialogue but do not show up in the edit - even after a save and restart!

However it is not correct to right click on the links above and select "Save as..." as you then get a copy of the relevant Github HTML page - which the Package manager will happily install for you but is invisible otherwise - like what I was getting and you seem to be as well.

Going to those linked to locations and saving the files correctly as XML ones means that they do load in and show up in the Editor as expected...

💡 Maybe we need to get around to make the Package manager actually report on whether it could parse the file it was given as a Mudlet item - IIRC much of the package/module handling is devoid of error reporting...

[Kebap]

@zesstra Does import work if you download the correct XML file?
E.g. https://raw.githubusercontent.com/Mundron/ASCII-Mapper-2.0/master/ASCIIMapper_Mundron.xml

[zesstra]

Actually, yes, that is the issue. I agree, an error message would be nice. ;-)

[Kebap]

Package manager should also report success.
This is how it looks like right now:

That is right. Those two white flashes are all a user can see.
For the record, the first announces the package's download.
The second will ask for patience while unpacking the package.

Now both operations succeed so quickly, you can't even identify let alone read the popups.
It would make sense to leave a message in chat inform about the result of said operations.

[Kebap]

Relevant files seem to be:

• https://github.com/Mudlet/Mudlet/blob/development/src/TLuaInterpreter.cpp - TLuaInterpreter::installPackage basically just redirects to Host.installPackage(location, 0);
• https://github.com/Mudlet/Mudlet/tree/development/src/Host.cpp - Host::installPackage(const QString& fileName, int module) has lots of returns and todos about missing error handling and itself invokes importPackage(&file2, packageName, module);
• https://github.com/Mudlet/Mudlet/blob/development/src/XMLimport.cpp - XMLimport::importPackage(QFile* pfile, QString packName, int moduleFlag, QString* pVersionString) goes through each item and seems to do even more legwork I didn't check or comprehend in detail, yet.

[Kebap]

I have added this now: