Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated string missing in application? #2251

Closed
Kebap opened this issue Jan 29, 2019 · 3 comments
Closed

Translated string missing in application? #2251

Kebap opened this issue Jan 29, 2019 · 3 comments
Labels
i18n & l10n internationalization and localization

Comments

@Kebap
Copy link
Contributor

Kebap commented Jan 29, 2019

Brief summary of issue / Description of requested feature:

Some strings were translated before, but translation is not visible in Mudlet anymore?!

Steps to reproduce the issue / Reasons for adding feature:

  1. For example, see [mudlet_de_DE.ts Line 5447](https://github.com/Mudlet/Mudlet/blame/development/translations/translated/mudlet_de_DE.ts#L5447 (currently) for a string from main_window.ui with English text like "opens the Editor for the different types of things that can be scripted by the user"
  2. Notice how it does show a German translation from 4 months ago. This is also the only string with that English content, just to be sure.
  3. Review Mudlet application. No translation is shown there, just the English string.
  4. Review Crowdin translations. No translation is stored there for this string. Only the TM has translation.

Error output / Expected result of feature

Both 3 and 4 should indeed keep and show the translations from 4 months ago, right?

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Not sure which strings are affected in total, but at least all tool-tips from all main menu options.

Screenshots for 3 and 4:

image

image

@Kebap Kebap added question i18n & l10n internationalization and localization labels Jan 29, 2019
@Kebap
Copy link
Contributor Author

Kebap commented Jan 29, 2019

So after looking at the string's sources a little more, they seem to have been modified 3 months ago, so a few weeks after translation, by this PR #2110 which did just capitalise the first letter and add a pair of <p> tags around the tool-tips where necessary.

So that means, these translations had been gone from Mudlet for quite a while already again.

It seems like this is related to #1961 in that regard.

@SlySven
Copy link
Member

SlySven commented Jan 29, 2019

ℹ️ FTR The <p>...</p> are the minimum needed to ensure that tooltip texts are treated as Rich-text so as to be formatted into a rectangular block of text which is easier on the eye than a long single line of text which is how it is handled if it is seen as plain text.

@Kebap
Copy link
Contributor Author

Kebap commented Apr 3, 2019

While that is interesting, I find no significance here.

Closing this issue now, as the other one is sufficient.

@Kebap Kebap closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n & l10n internationalization and localization
Projects
None yet
Development

No branches or pull requests

2 participants