New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing strings for translation #1964
Comments
Above mentioned strings in ctelnet.cpp sometimes have excessive space characters as in |
Thanks Vadi. Maybe there is something wrong with the search function here on github.com and I should really search the downloaded files myself. What a pity! |
SlySven reported:
|
@Kebap wrote:
The spacing in the This was done with the desire to ensure that all the messages have the same prefix length. However the existing code is not good for translations yet (I think I have code tucked away somewhere that {on language change} did a scan through all the translated headers and worked out the spacing to use for both them and any untranslated texts - even those with a single additional untranslated message marker prefix (the Qt default is ... however that has not been something that Vadim found if he was rummaging around in my previous I18n code attempts, assuming I ever published it... 😞 |
Let's move that discussion to #2005 shall we? |
main.cpp around this area, research "show_splash" |
Connection Popup will show "Cancel" button which stays in English and is not available for translation, yet. |
#### Brief overview of PR changes/additions Including many strings for translation, mostly related to connecting and disconnecting a profile. Removing strings from translations where they are not needed. Adjusting code to better grasp strings to translate. #### Motivation for adding to Mudlet Reduce English texts in translated Mudlet versions to mostly only texts used internally. #### Other info (issues closed, discussion etc) As discussed in #1964 and #2010 and Crowdin
Re: Splash screen text - translation is not straightforward because the splash-screen is displayed before the main UI is constructed and the translation system is loaded. I solved this in at least one of my versions that allowed run-time changes in the UI language without restarting Mudlet by: writing the translated strings out as a IIRC I also included a first entry being a count of the number of lines to avoid nasty problems if the number of different texts changed in later versions of Mudlet so that there was less lines in the variable than the code expected!) On starting up Mudlet would load the default ( |
That is because the standard dialogue buttons are provided by the Qt library and the hackary done by Vadim to simplify my run-time UI changing code did not quite get it right. My old code would, IIRC, allow the translation files source to be changed - so that one could change from a compiled-in set in a resource to an external set in the file-system - which could be edited on the fly and then reloaded; this meant that it had to check what translation files were available - by trying to load each one but not putting it into use - every time the |
💡 I've got some code stashed to one side that will sort out that aspect of the Editor... 😀 |
Closing a profile without autosave - "Would you like to save this profile" will be translated, but not the options for answering: "Yes", "No", "Maybe" ah I mean "Cancel" |
edit: dlgTriggerEditor.cpp lists these texts here: Mudlet/src/dlgTriggerEditor.cpp Line 602 in 4dfafa2
|
Just need to update Crowdin strings to make those available! |
In retrospect, we should have updated them as soon as development got merged. |
I believe all of these are updated now, right? |
I am not sure about all, haven't checked them in a while. For some, I am not even sure where they originate from. SlySven even mentioned some standard dialog buttons which didn't get translated at all. |
So I went through and checked all of them, and the only thing left to tackle here, is the start-up splash screen. |
What about simply removing the text from the splash screen? For most machines it starts too fast to read, and the information there is hardly useful or essential. |
Fair enough, closing this then. |
Brief summary of issue / Description of requested feature:
A few messages in client are not yet marked for translation, would not be localized as of today:
To be continued..
The text was updated successfully, but these errors were encountered: