Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Margin enum values #8650

Open
2 tasks done
BieleckiLtd opened this issue Apr 11, 2024 · 1 comment · May be fixed by #8844
Open
2 tasks done

Rename Margin enum values #8650

BieleckiLtd opened this issue Apr 11, 2024 · 1 comment · May be fixed by #8844
Assignees
Labels
enhancement New feature or request wants to do a PR

Comments

@BieleckiLtd
Copy link
Contributor

Feature request type

Enhance component

Component name

Various

Is your feature request related to a problem?

I find Margin.None confusing because I would expect it to mean 'no margin' (something denser than Dense).

Describe the solution you'd like

I suggest renaming it to Default, because that's what it is.

    public enum Margin
    {
        [Description("default")]
        Default,
        [Description("dense")]
        Dense,
        [Description("normal")]
        Normal
    }

Have you seen this feature anywhere else?

No response

Describe alternatives you've considered

No response

Pull Request

  • I would like to do a Pull Request

Code of Conduct

  • I agree to follow this project's Code of Conduct
@BieleckiLtd BieleckiLtd added enhancement New feature or request triage labels Apr 11, 2024
Copy link

👋 Thanks for wanting to do a PR @BieleckiLtd !
We will try to merge all (non-breaking) bugfix PRs and we will deliberate the value of feature PRs for the community. But be warned that there is no guarantee that new features will be merged. If you want to be sure before investing the work please contact the team about your planned feature PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wants to do a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants