Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does RImpala.java use "hive" connectors? #11

Open
lucacerone opened this issue Nov 4, 2016 · 0 comments
Open

Why does RImpala.java use "hive" connectors? #11

lucacerone opened this issue Nov 4, 2016 · 0 comments

Comments

@lucacerone
Copy link

Hi, I am sure this is not a proper bug because everything works fine.

I have a few curiosities about the code though. In RImpala.java you use
JDBC_DRIVER_NAME = "org.apache.hive.jdbc.HiveDriver";
and also you build the connection url as:
CONNECTION_URL = "jdbc:hive2://" + IP + ':' + port + "/;" + principal;

I wonder why you use Hive drivers and Hive2 protocol.

Reading at the documentation I had the impression one should use Impala drivers like:
com.cloudera.impala.jdbc3.Driver

and build the string using jdbc:impala//etc_etc

Am I missing something here?

Also I have a small suggestion: why don't you put the relevant .jar files in a folder "jars" in the inst directory (http://r-pkgs.had.co.nz/inst.html) and have rimpala.init() default to
file.path(system.file(package = "RImpala"),"jars")?

This way the user does not have to worry to install the jars and can still change them should she want to use a different location!

Anyway, thanks a lot for the great package!

Cheers,
Luca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant