From a7f725fbe83419b6743e9231ac7d41a4e26353bd Mon Sep 17 00:00:00 2001 From: Ben Junya Date: Fri, 22 Mar 2019 13:28:01 -0700 Subject: [PATCH 1/5] Avoid gender per @pauldariye #51 --- book/008-Modern-JS-Architecture.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/book/008-Modern-JS-Architecture.md b/book/008-Modern-JS-Architecture.md index c79e45fe..8e808ee0 100644 --- a/book/008-Modern-JS-Architecture.md +++ b/book/008-Modern-JS-Architecture.md @@ -23,7 +23,7 @@ There's 3 major aspects of a modern front end system: # Task runners -Back in the ancient JavaScript civilizations of 2013, brave warrior and huntress tribes of developers used `grunt` to start automating repetitive and menial tasks. +Back in the ancient JavaScript civilizations of 2013, brave tribes of developers used `grunt` to start automating repetitive and menial tasks. With the advent of Node.js, there were more and more tools that started appearing in the JavaScript ecosystem. We were able to use the command line to: From 179291968a50e3a2c5f24bf697e272b0e7d83139 Mon Sep 17 00:00:00 2001 From: Ben Junya Date: Fri, 22 Mar 2019 13:34:38 -0700 Subject: [PATCH 2/5] Fix #73 on Set per suggestion from @marwahaha --- book/003-complex-data-types.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/book/003-complex-data-types.md b/book/003-complex-data-types.md index cbb03159..873988d7 100644 --- a/book/003-complex-data-types.md +++ b/book/003-complex-data-types.md @@ -261,12 +261,14 @@ Under the hood, if an object has no more references pointing to it, it will be c # Set and WeakSet -Set and WeakSet are identical to Map, except for 2 major differences: +Set and WeakSet are identical to Map, except for a few major differences: -1. Instead of `.set` for values, you use `.add()` to create a key value pair to store. -2. All values in a `Set` must be unique and only occur once. +1. `Set` is a store of just `values` - not `key-value pairs` like in `Map`. +2. Instead of `.set` for values, you use `.add()` to store a value. +3. All values in a `Set` must be unique and only occur once. +4. Set is *ordered by insertion*. -As far as everything else, they are very identical and are ordered. +As far as everything else, they are very identical. If you need a `Map`-like storage or cache, but all values must be unique, then `Set` is *perfect*! From 99935f8201be8bf4c20c560380d888cb725828ba Mon Sep 17 00:00:00 2001 From: Ben Junya Date: Fri, 22 Mar 2019 13:41:23 -0700 Subject: [PATCH 3/5] Add @marwahaha to contributors --- README.md | 1 + src/pages/index.js | 3 +++ 2 files changed, 4 insertions(+) diff --git a/README.md b/README.md index c766c25c..7ce2727e 100644 --- a/README.md +++ b/README.md @@ -81,3 +81,4 @@ This book would not have been possible for the several contributors that have gr * [rw251](https://www.github.com/rw251) - Proofreading * [jessmear](https://www.github.com/jessmear) - Proofreading and content suggestion * [pauldariye](https://www.github.com/pauldariye) - Proofreading and example edits +* [marwahaha](https://www.github.com/marwahaha) - Proofreading and fixing misinformation on `Set` diff --git a/src/pages/index.js b/src/pages/index.js index 714cbcd2..dcb50cb8 100644 --- a/src/pages/index.js +++ b/src/pages/index.js @@ -79,6 +79,9 @@ const IndexPage = (): Node => {
  • pauldariye - Proofreading and example edits
    • +
  • + marwahaha - Proofreading and fixing misinformation on Set. +
    • ); From 8687c389701182fb9170b74d049a3a439f592f75 Mon Sep 17 00:00:00 2001 From: Ben Junya Date: Fri, 22 Mar 2019 13:45:21 -0700 Subject: [PATCH 4/5] Remove point 4 on Set. Bold text as well --- book/003-complex-data-types.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/book/003-complex-data-types.md b/book/003-complex-data-types.md index 873988d7..fbf04bb5 100644 --- a/book/003-complex-data-types.md +++ b/book/003-complex-data-types.md @@ -266,9 +266,8 @@ Set and WeakSet are identical to Map, except for a few major differences: 1. `Set` is a store of just `values` - not `key-value pairs` like in `Map`. 2. Instead of `.set` for values, you use `.add()` to store a value. 3. All values in a `Set` must be unique and only occur once. -4. Set is *ordered by insertion*. -As far as everything else, they are very identical. +As far as everything else, they are very identical, including being **ordered by insertion**. If you need a `Map`-like storage or cache, but all values must be unique, then `Set` is *perfect*! From 9b98764315bd8bfb28bdc61ffc1945a468db1fec Mon Sep 17 00:00:00 2001 From: Ben Junya Date: Fri, 22 Mar 2019 13:50:53 -0700 Subject: [PATCH 5/5] Change container to 680px total width per @revelt in #64 --- stylesheet.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stylesheet.css b/stylesheet.css index 3921567f..df971377 100644 --- a/stylesheet.css +++ b/stylesheet.css @@ -627,7 +627,7 @@ pre tt:after { .container { position: relative; margin: 0 auto; - max-width: 992px; + max-width: 680px; /* For typograpy! */ padding: 0px 1.0875rem 1.45rem; padding-top: 0; }