Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete Documentation in Regards to OpenJDK-11 #442

Open
Aurtikent opened this issue Nov 27, 2023 · 11 comments
Open

Obsolete Documentation in Regards to OpenJDK-11 #442

Aurtikent opened this issue Nov 27, 2023 · 11 comments
Assignees
Labels
Enhancement New feature or request

Comments

@Aurtikent
Copy link

Is your feature request related to a problem?

No



Describe the solution or enhancement you'd like

A clear and concise description of what you want to happen.

Update documentation to reflect changes.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered (if any).
Soultion 1:

openjdk-11 was removed from latest Debian's 12 repos thus making the documentation obsolete,

sudo apt install openjdk-11-jre*

will not work as mentioned in the documentation

i suggest to change the documentation for linux based disto's based on debain and their derivatives (ubuntu parrot kali etc)

Soultion 2:

Update the project to use jdk 17 or later for the same,
this would still require to update the documentation.

Same applies for using electron@11 but its not that big if a issue because you can still install it through npm.

@Morsmalleo
Copy link
Owner

Morsmalleo commented Nov 27, 2023

You've gotta be joking me.... Shit, I'll do what I can for this one, I had no idea jdk11 was discontinued in Debian

@Morsmalleo
Copy link
Owner

Morsmalleo commented Nov 28, 2023

Is your feature request related to a problem?
No

Describe the solution or enhancement you'd like
A clear and concise description of what you want to happen.

Update documentation to reflect changes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered (if any). Soultion 1:

openjdk-11 was removed from latest Debian's 12 repos thus making the documentation obsolete,

sudo apt install openjdk-11-jre*

will not work as mentioned in the documentation

i suggest to change the documentation for linux based disto's based on debain and their derivatives (ubuntu parrot kali etc)

Soultion 2:

Update the project to use jdk 17 or later for the same, this would still require to update the documentation.

Same applies for using electron@11 but its not that big if a issue because you can still install it through npm.

Also as for electron v11, yes I know this an older electron version but it's a step up from the version of electron AhMyth used before the release of Beta.4 which was 9.0.0^, don't worry support for recent electron version is the aim, so that will be taken care of

@Morsmalleo Morsmalleo added the Enhancement New feature or request label Nov 28, 2023
@Morsmalleo
Copy link
Owner

Morsmalleo commented Nov 28, 2023

Screw debian, I'm not giving up, I'll add JDK 17 support somehow, I don't know how or when this will be done, but damn it, I'm not giving up on this project.

@Aurtikent Aurtikent changed the title Obselate Documentatin in Rehards to OpenJDK-11 Obselate Documentatin in Regards to OpenJDK-11 Nov 28, 2023
@Aurtikent Aurtikent changed the title Obselate Documentatin in Regards to OpenJDK-11 obsolete Documentatin in Regards to OpenJDK-11 Nov 28, 2023
@Aurtikent Aurtikent changed the title obsolete Documentatin in Regards to OpenJDK-11 Obsolete Documentation in Regards to OpenJDK-11 Nov 28, 2023
@Aurtikent
Copy link
Author

Edit: Changed Title to Remove Typo's (English isn't my first language apologies)

For anyone facing this Issue please Refer to the following Reddit Thread.

https://www.reddit.com/r/debian/comments/14fjgus/need_help_installing_openjdk11_on_debian_12/

@Morsmalleo
Copy link
Owner

Morsmalleo commented Nov 28, 2023

Edit: Changed Title to Remove Typo's (English isn't my first language apologies)

For anyone facing this Issue please Refer to the following Reddit Thread.

https://www.reddit.com/r/debian/comments/14fjgus/need_help_installing_openjdk11_on_debian_12/

Looks like this one might be easier fixed than I imagined, a comment on seperate Reddit post that I read states that Java 1 code runs under Java 11, so therefore I'd imagine that Java 8 code (Apktool) will run under Java 17

@Morsmalleo
Copy link
Owner

Is your feature request related to a problem?
No

Describe the solution or enhancement you'd like
A clear and concise description of what you want to happen.

Update documentation to reflect changes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered (if any). Soultion 1:

openjdk-11 was removed from latest Debian's 12 repos thus making the documentation obsolete,

sudo apt install openjdk-11-jre*

will not work as mentioned in the documentation

i suggest to change the documentation for linux based disto's based on debain and their derivatives (ubuntu parrot kali etc)

Soultion 2:

Update the project to use jdk 17 or later for the same, this would still require to update the documentation.

Same applies for using electron@11 but its not that big if a issue because you can still install it through npm.

Ok, so I believe that I may have solved this problem, I just need to run further tests to confirm that everything does what it's supposed to do.

The recent release of Apktool v2.9.1 added build support for Java 21, so I attempted to build a snapshot of Apktool from its source code with Java 21 and so far everything is working with AhMyth with Java 21, however this is still not officially confirmed to be a fix, I need to do further testing to confirm if AhMyth will work the ways it's supposed to in terms of Decompiling and Compiling with Java 21 support added to the snap of Apktool utilised by AhMyth

@Morsmalleo
Copy link
Owner

Is your feature request related to a problem?
No

Describe the solution or enhancement you'd like
A clear and concise description of what you want to happen.
Update documentation to reflect changes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered (if any). Soultion 1:
openjdk-11 was removed from latest Debian's 12 repos thus making the documentation obsolete,

sudo apt install openjdk-11-jre*

will not work as mentioned in the documentation
i suggest to change the documentation for linux based disto's based on debain and their derivatives (ubuntu parrot kali etc)
Soultion 2:
Update the project to use jdk 17 or later for the same, this would still require to update the documentation.
Same applies for using electron@11 but its not that big if a issue because you can still install it through npm.

Ok, so I believe that I may have solved this problem, I just need to run further tests to confirm that everything does what it's supposed to do.

The recent release of Apktool v2.9.1 added build support for Java 21, so I attempted to build a snapshot of Apktool from its source code with Java 21 and so far everything is working with AhMyth with Java 21, however this is still not officially confirmed to be a fix, I need to do further testing to confirm if AhMyth will work the ways it's supposed to in terms of Decompiling and Compiling with Java 21 support added to the snap of Apktool utilised by AhMyth

Yeah this is solved from what I can see, I'll run some more tests just to confirm, if everything is all good I'll push the updates for Java 21 support in AhMyth immediately and I'll update the documentation as well

@Morsmalleo
Copy link
Owner

Morsmalleo commented Feb 1, 2024

It's solved, a new slightly modified version of Apktool was built with Java 21 and works perfectly, it even works perfectly with Java Versions starting from 8, going all the way up to 21.

I also updated the function that checks the users Java version as well, the function now accepts any version of Java 8 all the way up to Java 21 when Decompiling and/or Building and Signing.

These updates won't be available until the next major version of AhMyth is released, which will be v1.0-beta.6

@Morsmalleo
Copy link
Owner

The documentation will also be updated accordingly when the new release is out as well

@Aurtikent
Copy link
Author

Thanks ! I came in just to check on here,

Although i did notice you have a lot of junk commits which do not really do anything ,that's just a tad bit strange,
is everything ok?

@Morsmalleo
Copy link
Owner

Morsmalleo commented Feb 2, 2024

Thanks ! I came in just to check on here,

Although i did notice you have a lot of junk commits which do not really do anything ,that's just a tad bit strange, is everything ok?

All junk commits that does have proper titles and explanations are basically me remember everything I'm doing, I have to backup updated code as well as new code for upgrades as well, otherwise due to memory issues I'm having from an unknown health issue, development gets hard.... Explanation below

https://github.com/Morsmalleo/AhMyth/tree/master/.github/Dev#ahmyth-updates--upgrades

Then some people think it's ok to take advantage of the fact that I have memory problems and expect me to not remember my own work when I come across it like GitHub user AuxGrep when he stole the work I did on AhMyth 1.0-beta.3b and claimed it was all done by him...

Anyway yeah if commits are like this with a decent title

ed4ec4b

Then it's most likely just me backing up code so I don't forget it, proper commits that ACTUALLY update code, fix bugs, bring new features etc, will have proper commit titles and commit messages on them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants