Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USPTO processing pipeline: "remove_unsanitizable" implies "trim_rxn_smiles" called before #13

Open
Academich opened this issue Nov 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Academich
Copy link

I have a task that requires USPTO with only sanitizable molecules but also with CXSMILES information retained. However, if I keep CXSMILES, the "remove_unsanitizable" pipeline step tries to sanitize products together with CXSMILES and naturally fails, which results in 700k reactions being invalidated. It would be nice if the product SMILES never ended up containing CXSMILES when being processed by RDKit, even if CXSMILES were not removed.

@SGenheden
Copy link
Contributor

Thanks for your feedback.
This is on our to-do list. It would naturally be better to parse the CXSMILES correct, which would entail employing level-1 parenthesis around SMILES that should be considered as one molecule.

@SGenheden SGenheden added the enhancement New feature or request label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants