Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick optimization look up from torsiondrives #712

Open
jthorton opened this issue Mar 24, 2022 · 1 comment
Open

Quick optimization look up from torsiondrives #712

jthorton opened this issue Mar 24, 2022 · 1 comment

Comments

@jthorton
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When trying to diagnose why a torsiondrive has failed it is not clear which optimizations are the cause of this, leading me to reuse a function that queries the client for all optimizations associated with the record and then filter by an incomplete or error status. It would be great if we could add this feature to the torsiondrive record to save re-writing/ copying the function into each notebook.

Describe the solution you'd like
A function that queries all optimizations associated with a torsiondrive and filters by status to quickly find errored calculations.
something like record.get_optimizations(status: Optional[RecordStatusEnum] = None) -> List[OptimizationRecord]

Describe alternatives you've considered

Currently copy and past/ re-write a function that does this each time I need it.

Additional context

@bennybp
Copy link
Contributor

bennybp commented Sep 14, 2023

Interesting idea for v0.50. I think this would be easy, even if it only wraps existing functions. I would probably want it somewhat generic so that it would work with all records (with child records).

It is also possible to use the client query_records function, setting parent_id to the id of the torsiondrive, and setting the status to be whatever you are looking for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants