Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a record for qchem geometry optimization #29

Open
mattwelborn opened this issue Mar 6, 2020 · 7 comments
Open

Add a record for qchem geometry optimization #29

mattwelborn opened this issue Mar 6, 2020 · 7 comments

Comments

@mattwelborn
Copy link
Contributor

I don't have a license...

@dgasmith
Copy link
Contributor

dgasmith commented Mar 7, 2020

Are you looking for the output file of a geometry optimization or two? Any particular molecule?

@mattwelborn
Copy link
Contributor Author

mattwelborn commented Mar 8, 2020 via email

@dgasmith
Copy link
Contributor

dgasmith commented Mar 8, 2020

For parsing optimizations from pure log files you might want to look in cclib. You start to need state machines to parse this kind of output well.

output.txt

@mattwelborn
Copy link
Contributor Author

Thanks. Out of curiosity, why don't we just use cclib as the base parser for qcng and supplement when additional data are available? (e.g. read the qchem output log with cclib, translate to qcsk, then read the scratch folder with qcng)

@dgasmith
Copy link
Contributor

dgasmith commented Mar 9, 2020

Generally cclib doesn't parse enough to be valid in schema land so we need to reparse the majority of the quantities regardless. The primary exception to this is their parsing of composite quantities like geometry optimizations where most codes do not have binary representations thereof.

@mattwelborn
Copy link
Contributor Author

Okay. In that case, it doesn't seem worth introducing a cclib dependency. In the past, I wrote a state machine parser for qchem output, but I think we can skate by with a very simple state machine + what we already have. Basically, use a regex to split the geometry optimization frames apart and parse each one as an AtomicResult. Any objections?

@dgasmith
Copy link
Contributor

dgasmith commented Mar 9, 2020

Not on my end, Q-Chem has a nice regular structure to it. Some other programs use different print outs for individual gradients which makes things difficult.

@dgasmith dgasmith removed their assignment Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants