Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item_texture.json and terrain_texture.json was replaced instead of being merged (1.20.70) #43

Closed
NSPC911 opened this issue Mar 17, 2024 · 4 comments

Comments

@NSPC911
Copy link

NSPC911 commented Mar 17, 2024

Not sure how the mistake appeared, but in the latest release, the item_texture.json and terrain_texture.json had decreased in file size drastically. Looking via GitLens (it doesn't show up on blame), I saw this for item_texture.json:

image

My suspicion is that instead of merging with the main branch, it replaced it, so the older code was gone and the new items are left. I hope this gets fixed in 1.20.80.

@NSPC911 NSPC911 changed the title item_texture.json was replaced instead of merged (1.20.70) blocks.json, item_texture.json and terrain_texture.json was replaced instead of merged (1.20.70) Apr 1, 2024
@NSPC911 NSPC911 changed the title blocks.json, item_texture.json and terrain_texture.json was replaced instead of merged (1.20.70) blocks.json, item_texture.json and terrain_texture.json was replaced instead of being merged (1.20.70) Apr 1, 2024
@NSPC911
Copy link
Author

NSPC911 commented Apr 1, 2024

I can attempt to open a Pull Request to fix this, but highly doubt that it will be merged

@NSPC911 NSPC911 changed the title blocks.json, item_texture.json and terrain_texture.json was replaced instead of being merged (1.20.70) item_texture.json and terrain_texture.json was replaced instead of being merged (1.20.70) Apr 1, 2024
@NSPC911
Copy link
Author

NSPC911 commented Apr 1, 2024

Fixed it in #44

@mammerla
Copy link
Collaborator

Sorry for the delay in getting to this. I have a PR of this fix that I built out using my updated process (for preview) at #48, with the intent to merge this in for main/preview branches soon.. LMK if you have feedback.

@NSPC911
Copy link
Author

NSPC911 commented May 2, 2024

Fixed in #48 , closed issue

@NSPC911 NSPC911 closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants