Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow list to be shared to the public #126

Open
MFYDev opened this issue Apr 26, 2024 · 2 comments
Open

[Feature Request] Allow list to be shared to the public #126

MFYDev opened this issue Apr 26, 2024 · 2 comments
Labels
feature request New feature or request

Comments

@MFYDev
Copy link

MFYDev commented Apr 26, 2024

Just like title said, would be very appreciated if the list can be shared to with public access, which is pretty useful sometimes.

@MohamedBassem MohamedBassem added the feature request New feature or request label Apr 26, 2024
@MohamedBassem
Copy link
Collaborator

MohamedBassem commented Apr 26, 2024

This makes sense as a feature request. Do you have examples in mind for when this can be useful?

EDIT: For example, do you expect people to see the notes you attached to your bookmarks in that list? Also, I assume all bookmarks (and the list) would be immutable, right?

@MFYDev
Copy link
Author

MFYDev commented Apr 29, 2024

Thank you so much for the fast reply, did not expect the response could be this fast and sorry for the delay.

If you want this to be a perfect feature, I would say add option for users to choose when they sharing it, let them choose whether they want to share the notes or not.

Temporarily I would say the list should just be the same as the list in the backend when it is shared, this is easier. And after the first step is developed, I think just like I said above, add an option for it, ask user to choose whether they want the list to be updated when they change it or it should be just a static one which is immutable. Because I have not read the code yet I have no idea which is easier, but I would say either this two has finished can trigger a release cause it will be a nice feature to have asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants