Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Drag and Drop Items to Lists #123

Open
MikeKMiller opened this issue Apr 25, 2024 · 5 comments
Open

[Feature request] Drag and Drop Items to Lists #123

MikeKMiller opened this issue Apr 25, 2024 · 5 comments
Labels
feature request New feature or request

Comments

@MikeKMiller
Copy link

It would be helpful for organization to allow drag and drop from the main bookmark view to lists on the left menu. This would allow quickly moving items into the lists, versus the current (Click the 3 dots, Click Add to List, Click to select a List, Click Save)

@MohamedBassem MohamedBassem added the feature request New feature or request label Apr 25, 2024
@kamtschatka
Copy link
Contributor

I created a POC for that.
I added a special handle for dragging the item around, to avoid people dragging and dropping everything all the time:
image

Then you simply drag it to the side and drop it on a list (I have excluded "Archive" and "Favourite" here, but idk)
image

Opinions?

kamtschatka pushed a commit to kamtschatka/hoarder-app that referenced this issue May 16, 2024
added drag and drop possibility for adding bookmarks to lists
@MohamedBassem
Copy link
Collaborator

@kamtschatka you seem to have became an expert in drag and dropping! I like the feature! I think one thing that would make it look nicer is that when you're dragging the bookmark instead of changing the opacity, we can just replace the bookmark card with something simpler (e.g. a title only card for example).

kamtschatka pushed a commit to kamtschatka/hoarder-app that referenced this issue May 17, 2024
reused the drag and drop functionality for tags also for dragging and dropping bookmarks into lists
kamtschatka pushed a commit to kamtschatka/hoarder-app that referenced this issue May 17, 2024
reworked the drag and drop mechanism again to still have change detection, but not so much that it has a huge overhead
pushed down the drag and drop handling to the components
@kamtschatka
Copy link
Contributor

I have pushed all my changes to a branch, that makes this in theory possible (i am able to change the dragged element, when it is dragged), but I am not skilled enough to get that to work^^
When you start dragging, it changes appearance, but that means:

  • The new (smaller) div will be at the same top/left coordinates the previous div was --> the mouse cursor is not even on the element anymore. No idea how to fix that ^^
  • Funnily the next bookmark will move into the new space. That will cause an image to be directly below the mouse, which will then start dragging the image, which will then cause the UI to show the "Drop your image" overlay, to upload images.... Also no idea how to fix that^^

kamtschatka pushed a commit to kamtschatka/hoarder-app that referenced this issue May 18, 2024
reworked the drag and drop mechanism to still have change detection, but not so much that it has a huge overhead
Changed the layout a bit to allow proper drag/drop of elements from the main section to the sidebar
Added the possibility to drag/drop bookmarks onto lists
@kamtschatka
Copy link
Contributor

OK, got something working, looks like this now:
image

@MohamedBassem
Copy link
Collaborator

@kamtschatka looks amazing <3 Will review the PR hopefully either today or tomorrow. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants