Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Update dist min JS to match src JS #131

Open
PawelGlow opened this issue Aug 8, 2019 · 1 comment
Open

Update dist min JS to match src JS #131

PawelGlow opened this issue Aug 8, 2019 · 1 comment

Comments

@PawelGlow
Copy link

PawelGlow commented Aug 8, 2019

https://github.com/Mobius1/Selectr/blob/master/dist/selectr.min.js does not match https://github.com/Mobius1/Selectr/blob/master/src/selectr.js.

This creates a issue when you include the lib using NPM, it loads the obsolete file from the dist folder which is specified in the package.json "main": "dist/selectr.min.js".

To see the difference search for this phrase this.select(0); and notice the dist min JS file is missing this IF condition: this.config.data.length > 0.

@brimimc
Copy link

brimimc commented Nov 4, 2019

This is a huge issue for us as the XSS fixes from 8 months ago are not included in the dist/selectr.min.js (works fine using the src selectr.js. How is the min file created and can we get the npm package updated properly??

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants