Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InventoryOpener's fill method does not work for some inventory types #187

Open
ImDxni opened this issue Jun 5, 2021 · 2 comments
Open
Labels

Comments

@ImDxni
Copy link

ImDxni commented Jun 5, 2021

Hi, i was trying to do stuffs with SmartInvs, i was using the Dropper InventoryType and i found a problem. In the InventoryOpener interface, the default method fill (that is called by SpecialInventoryOpener) uses this code:

fill method

But this code can be used only for inventories with 9 columns, so inventorytypes like dropper aren't supported by this fill method, if you try to add an item in a dropper it gives error because of the plugin treats the inventory as if it has 9 columns (IndexOutOfBoundsException)

@MinusKube MinusKube added the bug label Jun 5, 2021
@MinusKube
Copy link
Owner

Indeed, it is a problem. I think you can currently workaround this by giving a size of 1 row and 9 columns to the inventory, but this is not very intuitive.

@ImDxni
Copy link
Author

ImDxni commented Jun 5, 2021

I directly rewrited the fill method

@MinusKube MinusKube changed the title InventoryOpener issue InventoryOpener's fill method does not work for some inventory types Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants