-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory Rework #1992
base: master
Are you sure you want to change the base?
Inventory Rework #1992
Conversation
src/main/java/net/minestom/server/inventory/click/ClickResult.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickPreprocessor.java
Outdated
Show resolved
Hide resolved
src/test/java/net/minestom/server/inventory/click/type/InventoryCopyCursorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got part of the way through reviewing, but ill wait for re-remapped ids
@GoldenStack please make sure these cases do not bypass events in this PR #1932 |
This will fix #1932, yes; offhand swaps become |
cb1b260
to
db1b9c2
Compare
032727b
to
12ad399
Compare
2e60d18
to
8b1ad41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will prob nitpick again later, but this is what I have for now
src/main/java/net/minestom/server/event/trait/InventoryEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickPreprocessor.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickPreprocessor.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickResult.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickResult.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickResult.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickResult.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickResult.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickResult.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minestom/server/inventory/click/ClickPreprocessor.java
Outdated
Show resolved
Hide resolved
|
||
} | ||
|
||
private static final @NotNull StackingRule RULE = StackingRule.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StackingRule
will most likely disappear in 1.20.5
8a7a7a7
to
eff1b5e
Compare
e1f4190
to
4ad72ac
Compare
9a60d0f
to
1573b34
Compare
420db7e
to
6b80644
Compare
Hey, I still haven’t figured out how to use the inventory after Inventory Rework PR. How can I block a slot? To prevent a player from taking an item from a slot, to prevent a player from putting an item into a slot |
dc9c696
to
5c23694
Compare
fbf574f
to
0695ca1
Compare
f02082e
to
df3051f
Compare
Rework of the inventory system.
Recreation of hollow-cube#132
Main changes:
Changes: