Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod List scales incorrectly on HiDPI Setups #6162

Closed
juliand665 opened this issue Sep 17, 2019 · 3 comments · Fixed by #6170
Closed

Mod List scales incorrectly on HiDPI Setups #6162

juliand665 opened this issue Sep 17, 2019 · 3 comments · Fixed by #6170
Labels
1.14 Bug This request reports or fixes a new or existing bug.

Comments

@juliand665
Copy link
Contributor

juliand665 commented Sep 17, 2019

Minecraft Version: 1.14.4

Forge Version: 28.1.6

Logs: https://gist.github.com/juliand665/05f1b6b2ee1201750621ae907e5d2464

Steps to Reproduce:

  1. Start up the game
  2. Click the "Mods" button
  3. (Optionally) click any mod to see the full effect of the issue

Description of issue:
On setups with more than 1 pixel per point (tested on a Mac with retina display, but it might happen on other OSs too), the mod list description area is cut off. You can't scroll up either, it's purely visual.

Without HiDPI:
Screen Shot 2019-09-17 at 15 03 45

With HiDPI:
Screen Shot 2019-09-17 at 15 03 54

Looks like this is the same issue as #5996, although that one was less than helpful.

@juliand665 juliand665 added the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Sep 17, 2019
@LordMonoxide
Copy link
Contributor

This isn't an issue in Windows 10. I use a 4K TV at 200% scale.

@juliand665
Copy link
Contributor Author

Interesting, so I guess it is macOS specific after all.

@gigaherz
Copy link
Contributor

Could be differences in how hidpi is exposed (or hidden) from the app. Eg maybe one of the platforms "lies" to the app about the real dimensions of the screen while the other does not. In any case, it should be a matter of making sure the drawing dimensions are calculated based on the real pixel size of the opengl backbuffer, and not the virtual screen dimensions.

@gigaherz gigaherz added 1.14 Bug This request reports or fixes a new or existing bug. and removed Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. labels Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.14 Bug This request reports or fixes a new or existing bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants