Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.13.2] Options in a generated config.toml have the wrong order #5688

Closed
Ruuubi opened this issue Apr 12, 2019 · 3 comments
Closed

[1.13.2] Options in a generated config.toml have the wrong order #5688

Ruuubi opened this issue Apr 12, 2019 · 3 comments
Labels
1.13 Bug This request reports or fixes a new or existing bug. Confirmed This request has been verified to be factually correct by at least one member of the team.

Comments

@Ruuubi
Copy link

Ruuubi commented Apr 12, 2019 •
edited

Actually not sure if this is a bug, intended or if I'm doing something wrong here:
While using the Forge config system to create a toml-file, the output has a different order than in the source code. This results in a messed up config if you chose to put similar options together, because they can appear in a different order.

Example input and output: https://i.imgur.com/obD85Nx.png

Edit:
Tested with Forge-25.0.110
@tterrag1098 tterrag1098 added 1.12 Bug This request reports or fixes a new or existing bug. Confirmed This request has been verified to be factually correct by at least one member of the team. labels Apr 12, 2019
@MajorTuvok
Copy link
Contributor

Sorry for commenting, but this accidentally got the 1.12 label even though it's only relevant for 1.13...

@tterrag1098 tterrag1098 added 1.13 and removed 1.12 labels Apr 12, 2019
@tterrag1098 tterrag1098 mentioned this issue Apr 12, 2019
Merged
@tterrag1098
Copy link
Contributor

PR made upstream.

@tterrag1098 tterrag1098 added the Blocked Upstream This request's solution is awaiting a change on a project we depend on. label Apr 12, 2019
@TheElectronWill
Copy link

Fixed in NightConfig v3.5.3

@tterrag1098 tterrag1098 removed the Blocked Upstream This request's solution is awaiting a change on a project we depend on. label Apr 16, 2019
tterrag1098 added a commit to tterrag1098/MinecraftForge that referenced this issue May 11, 2019
@tterrag1098
Fix MinecraftForge#5688 config values are unordered, update Night-Config
8298c22
@Darkere Darkere mentioned this issue Aug 6, 2020
Closed
@EwyBoy EwyBoy mentioned this issue Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.13 Bug This request reports or fixes a new or existing bug. Confirmed This request has been verified to be factually correct by at least one member of the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tterrag1098 @TheElectronWill @Ruuubi @MajorTuvok