Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.13.2] Other mods' Access Transformers not applied while in a deobf environment #5620

Closed
Tamaized opened this issue Mar 17, 2019 · 3 comments
Assignees
Labels
1.13 Bug This request reports or fixes a new or existing bug.

Comments

@Tamaized
Copy link

Discovered this while debugging:
mezz/JustEnoughItems#1512 (comment)

To reiterate, I had placed a breakpoint here:
https://github.com/MinecraftForge/AccessTransformers/blob/2b9c7950bfd2e6b654fde244b789727eefaa8bc1/src/main/java/net/minecraftforge/accesstransformer/AccessTransformerEngine.java#L34
And I've noticed fn.name shows a mapped name while fieldTransformers contains all srg names (obviously) thus checking against .containsKey(fn.name) will always fail.
As shown here: https://cdn.discordapp.com/attachments/418125698486632448/556912816930684932/unknown.png

I did a test where instead of srg names in the dependency accesstransformer.cfg file, I used mapped names instead. Tossed the new test jar into my workspace and had no issues whatsoever.

@Tamaized Tamaized changed the title Other mods' Access Transformers not applied while in a deobf environment [1.13.2] Other mods' Access Transformers not applied while in a deobf environment Mar 17, 2019
@mezz mezz added Bug This request reports or fixes a new or existing bug. 1.13 labels Mar 18, 2019
@cpw
Copy link
Contributor

cpw commented Mar 18, 2019

I'll look at this next time I'm home. Sadly that's likely a week from now 😡

@cpw
Copy link
Contributor

cpw commented Mar 18, 2019

I already have infrastructure in place to try and help solve this.

@cpw
Copy link
Contributor

cpw commented Apr 6, 2019

Closing, implemented in cdbd842

@cpw cpw closed this as completed Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.13 Bug This request reports or fixes a new or existing bug.
Projects
None yet
Development

No branches or pull requests

3 participants