Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.13] Allow tags to contain not-present registry entries #5343

Closed
williewillus opened this issue Jan 11, 2019 · 3 comments
Closed

[1.13] Allow tags to contain not-present registry entries #5343

williewillus opened this issue Jan 11, 2019 · 3 comments

Comments

@williewillus
Copy link
Contributor

Mojang's datapack stuff has a tradition of throwing whenever it finds registry entries not actually present.
This makes sense for things like recipes/advancements which are useless if the named entries aren't actually there.

However, for tags, it's useful for integration purposes for a mod to predefined a bunch of foreign mods' blocks/items in their own tag json. This means if that tag is loaded where one of the foreign mods isn't present, it throws and none of the entries in the file load at all.

How do we feel about patching the loader to just continue on missing entry instead of throwing?

@MajorTuvok
Copy link
Contributor

We could maybe allow conditions to be added to TagEntries?

This would give people much more control over compound objects...

@LexManos
Copy link
Member

No conditions will not be added. That ads way to much complication to the system.
The only thing that is needed is a 'optional' identifier.
Similar to vanilla's '#' identifier for nesting tags.
They use ResourceLocations, which means [a-z0-9_.-] is the possible values for the namespace/beginning of the values.
Perhaps adding a ^ prefix for 'optional' entries.
Also it's been debated to expand the tag system to have a "remove":[] entry. Instead of the overwrite boolean.

@williewillus
Copy link
Contributor Author

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants