Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues with Capabilities event in ItemStacks #5035

Closed
Sir-Will opened this issue Jul 14, 2018 · 3 comments
Closed

Performance issues with Capabilities event in ItemStacks #5035

Sir-Will opened this issue Jul 14, 2018 · 3 comments

Comments

@Sir-Will
Copy link

I have been working on improving the performance of my server the past months and I did create and look through hundreds of nps files. During this time I did encounter multiple occasions where the EventBus#post of gatherCapabilities in the ItemStack class was showing up with a very long time.

It would be great if we can find a solution for this issue.

Profiling Screenshots ItemStack forgeInit: Botania: ![](https://i.imgur.com/3eSr8R2.jpg)

Thermal Dynamics:

RefinedStorage:

DankNull:

mcjtylib:

ExtraUtilties2:


forge-1.12.2-14.23.4.2705
@LexManos
Copy link
Member

LexManos commented Jul 14, 2018

Remove the mods that are being expensive. The event is as cheap as possible on our end as it can be.
Not to mention we dont support anything related to Sponge "performance issues".
And as always, the forums are where you wanna go for simple stuff like this.

@Sir-Will
Copy link
Author

Sir-Will commented Jul 14, 2018

That would be over 5 mods I would need to remove, that's not a solution.

@LexManos
Copy link
Member

That doesnt change the fact that we cant make a for loop any more efficient then it is already. If you cant live without the laggy mods then start yelling at the mod authors to be more efficient on their end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants