Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] DataFixer walker for capabilities #4551

Closed
williewillus opened this issue Nov 25, 2017 · 3 comments
Closed

[Suggestion] DataFixer walker for capabilities #4551

williewillus opened this issue Nov 25, 2017 · 3 comments
Labels
Stale This request hasn't had an update from the author in a long time.

Comments

@williewillus
Copy link
Contributor

Currently we can just register a fixer/walker for an existing IFixType and then trudge around in the raw compound looking for the capabilities subtag. This is tedious (every mod has to do a lot of boilerplate) and flaky (since it would break if Forge ever changed where caps are stored)

It would be nicer if Forge added an IFixType representing capabilities, then added walkers for LEVEL, PLAYER, CHUNK, BLOCK_ENTITY, ENTITY and ITEM_INSTANCE to automatically navigate to the cap tag and walk it.

@williewillus
Copy link
Contributor Author

If this sounds like a good idea, I can get working on a PR

@stale
Copy link

stale bot commented May 24, 2018

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___." or "Here's a screenshot of this issue on the latest version"). Thank you for your contributions!

@stale stale bot added the Stale This request hasn't had an update from the author in a long time. label May 24, 2018
@stale
Copy link

stale bot commented Jun 7, 2018

This issue has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.

@stale stale bot closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale This request hasn't had an update from the author in a long time.
Projects
None yet
Development

No branches or pull requests

1 participant