You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While this is the most common folder for nested jars, JarJar metadata defines nested jar paths as paths relative to the outer jar's root, and therefore nested jars can be located anywhere in the jar. This breaks mods that place their nested jars in other paths than the mentioned folder.
Expected behavior
SrgToMcpRenamer is able to deobfuscate any nested jars regardless of their location, as specified by JarJar metadata. Rather than assuming all nested jars are in the META-INF/jarjar/ directory, we should open the jar's JarJar metadata file and read nested jar paths from it.
The text was updated successfully, but these errors were encountered:
The Issue
Currently, only nested jars under the
META-INF/jarjar/
directory are deobfuscated bySrgToMcpRenamer
.InstallerTools/src/main/java/net/minecraftforge/installertools/SrgMcpRenamer.java
Line 132 in dd66a7d
While this is the most common folder for nested jars, JarJar metadata defines nested jar paths as paths relative to the outer jar's root, and therefore nested jars can be located anywhere in the jar. This breaks mods that place their nested jars in other paths than the mentioned folder.
Expected behavior
SrgToMcpRenamer
is able to deobfuscate any nested jars regardless of their location, as specified by JarJar metadata. Rather than assuming all nested jars are in theMETA-INF/jarjar/
directory, we should open the jar's JarJar metadata file and read nested jar paths from it.The text was updated successfully, but these errors were encountered: