DownloadUtils doesn't set a timeout, causing downloads to hang if a server doesn't respond

[Barteks2x]

This is one of java's dumb default:

ForgeGradle/src/common/java/net/minecraftforge/gradle/common/util/DownloadUtils.java

Lines 213 to 237 in 63b7583

	public static HttpURLConnection connectHttpWithRedirects(URL url, Consumer<HttpURLConnection> setup) throws IOException {
	HttpURLConnection con = (HttpURLConnection) url.openConnection();
	con.setInstanceFollowRedirects(true);
	con.addRequestProperty("Accept-Encoding", ACCEPT_ENCODING);
	setup.accept(con);
	con.connect();
	if ("http".equalsIgnoreCase(url.getProtocol())) {
	int responseCode = con.getResponseCode();
	switch (responseCode) {
	case HttpURLConnection.HTTP_MOVED_TEMP:
	case HttpURLConnection.HTTP_MOVED_PERM:
	case HttpURLConnection.HTTP_SEE_OTHER:
	String newLocation = con.getHeaderField("Location");
	URL newUrl = new URL(newLocation);
	if ("https".equalsIgnoreCase(newUrl.getProtocol())) {
	// Escalate from http to https.
	// This is not done automatically by HttpURLConnection.setInstanceFollowRedirects
	// See https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4959149
	return connectHttpWithRedirects(newUrl, setup);
	}
	break;
	}
	}
	return con;
	}

if you don't explicitly set a timeout value, it will wait indefinitely for a response that may never arrive.

Normally this works because you either get a response or it fails. But sometimes, in some random cases of network issues, there is no response at all and it will hang, waiting forever for a nonexistent response.

[LexManos]

Interesting. it depends on the javac implementation it seems. Anyways if you want to set a timeout feel free to submit a pr. I'm fine with whatever as this is a dumb edge case