Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version range matching sometimes does not give expected result #909

Open
PepperCode1 opened this issue Feb 8, 2023 · 0 comments
Open

Version range matching sometimes does not give expected result #909

PepperCode1 opened this issue Feb 8, 2023 · 0 comments

Comments

@PepperCode1
Copy link

PepperCode1 commented Feb 8, 2023

This issue was observed towards the end of the 1.19.3 porting process of Create. Create uses JarJar to include Flywheel so it does not need to be installed separately.

The JarJar configuration for Flywheel can be found here. The version range is set as [0.6.8,0.6.9) and the Flywheel version used is 0.6.8.a-1.

Building the mod fails because JarJar reports that 0.6.8.a-1 does not match [0.6.8,0.6.9). This result is consistent and the exact build log can be found here.

Strangely, this issue did not happen on 1.18.2 or 1.19.2, even though the ForgeGradle version did not change, and thus the JarJar version did not change either. What makes me think that this issue is a bug is because org.apache.maven.artifact.versioning.VersionRange.createFromVersionSpec("[0.6.8,0.6.9)").containsVersion(new org.apache.maven.artifact.versioning.DefaultArtifactVersion("0.6.8.a-1")) returns true.

@marchermans marchermans transferred this issue from MinecraftForge/JarJar Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant