New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolbarRender 下是否应该去除默认的Clone Icon #130

Open

TinsFox opened this issue Sep 30, 2022 · 1 comment

TinsFox commented Sep 30, 2022

在API设计上来说，开发者选择了toolbarRender，是不是应该不应该再加上默认的CloseIcon呢？因为我选择了就意味着我想自定义，保留默认的图标不一样会造成视觉的冲突。

我这里选择了别的图标库，现在这个CloseIcon就现在很突兀

Owner

MinJieLiu commented Oct 1, 2022

有道理，计划去掉

big-camel referenced this issue in big-camel/react-image-previewer


          refactor: 启用自定义工具栏时，移除 close 图标 #130

6fd240a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment