Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroying Shops or Removing Items needs Limiters #10

Open
Sleaker opened this issue Jul 15, 2011 · 1 comment
Open

Destroying Shops or Removing Items needs Limiters #10

Sleaker opened this issue Jul 15, 2011 · 1 comment
Labels

Comments

@Sleaker
Copy link
Member

Sleaker commented Jul 15, 2011

Destroying a shop should require the shop to be empty, or should remove items the player can not hold. Same with attempting to remove an item from a shop.

Shops with large amounts of items can cause a server crash or extreme lag by remove the shop or an item that has an immense stock level causing the server to attempt to create drops for all of the items into the world.

@cerealcable
Copy link
Member

We should just give a warning and refuse to delete a shop.

Example:

/shop destroy
-- If player has enough room the shop is destroyed and the player receives all items from the shop.
-- If player does not have enough room, the shop is not destroyed and as much as the player can
       safely hold is given to the player and then warned.  Repeating this command multiple times
       (assuming the player empties his inventory) should result in a destroyed shop.
Could not destroy shop!  Shop inventory is too large!
/shop destroy force
-- Destroys the shop and moves the file to a  folder for recovery???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants