Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on install #26

Open
anthonynorth opened this issue Apr 29, 2023 · 1 comment · May be fixed by #27
Open

Warning on install #26

anthonynorth opened this issue Apr 29, 2023 · 1 comment · May be fixed by #27

Comments

@anthonynorth
Copy link

An author entry in description is throwing a warning on install.

Warning in person1(given = given[[i]], family = family[[i]], middle = middle[[i]],  :
  It is recommended to use ‘given’ instead of ‘middle’.

reprex:

remotes::install_github("milesmcbain/tflow", force = TRUE)
#> Using github PAT from envvar GITHUB_PAT
#> Downloading GitHub repo milesmcbain/tflow@HEAD
#> Skipping 2 packages ahead of CRAN: rlang, vroom
#> Running `R CMD build`...
#> * checking for file ‘/tmp/Rtmpx9xkCB/remotes123897dd67c5d/MilesMcBain-tflow-5cd8607/DESCRIPTION’ ... OK
#> * preparing ‘tflow’:
#> * checking DESCRIPTION meta-information ... OK
#> * checking for LF line-endings in source and make files and shell scripts
#> * checking for empty or unneeded directories
#> Omitted ‘LazyData’ from DESCRIPTION
#> * building ‘tflow_0.3.8.tar.gz’
#> Installing package into ‘/home/anthony/R/x86_64-pc-linux-gnu-library/4.3’
#> (as ‘lib’ is unspecified)
#> * installing *source* package ‘tflow’ ...
#> ** using staged installation
#> Warning in person1(given = given[[i]], family = family[[i]], middle = middle[[i]],  :
#>   It is recommended to use ‘given’ instead of ‘middle’.
#> ** R
#> ** inst
#> ** byte-compile and prepare package for lazy loading
#> ** help
#> *** installing help indices
#> ** building package indices
#> ** testing if installed package can be loaded from temporary location
#> ** testing if installed package can be loaded from final location
#> ** testing if installed package keeps a record of temporary installation path
#> * DONE (tflow)

Created on 2023-04-29 with reprex v2.0.2

Session info
sessionInfo()
#> R version 4.3.0 (2023-04-21)
#> Platform: x86_64-pc-linux-gnu (64-bit)
#> Running under: Ubuntu 22.04.2 LTS
#>
#> Matrix products: default
#> BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.10.0
#> LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.10.0
#>
#> locale:
#>  [1] LC_CTYPE=en_AU.UTF-8       LC_NUMERIC=C
#>  [3] LC_TIME=en_AU.UTF-8        LC_COLLATE=en_AU.UTF-8
#>  [5] LC_MONETARY=en_AU.UTF-8    LC_MESSAGES=en_AU.UTF-8
#>  [7] LC_PAPER=en_AU.UTF-8       LC_NAME=C
#>  [9] LC_ADDRESS=C               LC_TELEPHONE=C
#> [11] LC_MEASUREMENT=en_AU.UTF-8 LC_IDENTIFICATION=C
#>
#> time zone: Australia/Brisbane
#> tzcode source: system (glibc)
#>
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base
#>
#> loaded via a namespace (and not attached):
#>  [1] digest_0.6.31     styler_1.9.1      fastmap_1.1.1     xfun_0.39
#>  [5] magrittr_2.0.3    remotes_2.4.2     glue_1.6.2        R.utils_2.12.2
#>  [9] knitr_1.42        htmltools_0.5.5   rmarkdown_2.21    lifecycle_1.0.3
#> [13] cli_3.6.1         R.methodsS3_1.8.2 vctrs_0.6.2       reprex_2.0.2
#> [17] withr_2.5.0       compiler_4.3.0    R.oo_1.25.0       R.cache_0.16.0
#> [21] purrr_1.0.1       tools_4.3.0       curl_5.0.0        evaluate_0.20
#> [25] yaml_2.3.7        rlang_1.1.1       fs_1.6.2
rmflight added a commit to rmflight/tflow that referenced this issue Apr 29, 2023
@rmflight rmflight linked a pull request Apr 29, 2023 that will close this issue
@rmflight
Copy link
Contributor

That seems likely that is my fault @anthonynorth , although why we've not seen that warning on this 📦 until now I don't know. I know I've had to fix it in other packages I maintain and am on. Anyway, hopefully @MilesMcBain will merge this PR and the warning will go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants