Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe mode: Add size and direct link option #268

Open
bargru opened this issue May 3, 2021 · 6 comments
Open

iframe mode: Add size and direct link option #268

bargru opened this issue May 3, 2021 · 6 comments

Comments

@bargru
Copy link

bargru commented May 3, 2021

First of all, thank you for the 1.4 release! The iframe mode is now running much smoother.

However, it would be nice if the following options were available for the iframe in the settings (as with the proxy):

Expected Behavior

  • Direct link to Grafana Panel (probably has to be solved via a button?).
  • Manual setting of the size of the iframe.

Current Behavior

Options are only available for proxy mode.

Possible Solution

None

Your Environment

  • Icinga Web 2 Grafana version (System - About): 1.4.2
  • Icinga Web 2 version and modules (System - About): 2.7.4
@n3k232
Copy link

n3k232 commented Jun 24, 2021

+1

1 similar comment
@Steppensturm
Copy link

+1

@cadirol
Copy link

cadirol commented Jul 15, 2021

Hi
First of all, thank you for the update!
After Upgrading i was a bit confused about the width of the Graphs in iframe Mode. As i can read in the comment from @bargru, the size of the iframe should be done via manual setting.
Did something changed with the iframe setting? The Graphs now looks smaller than before the upgrade.
... i know, maybe i am outdated with my question...
Thank you for your work!

@roman-rs
Copy link

roman-rs commented Dec 10, 2021

same here. the iframe width is much smaller than it's set in the graph settings.

If I enable repeated Yes in the graph settings, then all the repeated 10 iFrames are of correct width. but that cannot be a workaround, of course. in this case one graph is correct and useful and 9 frames with empty graphs as it cannot find all the non-existing panelIds. Turn of the repeated setting, and width is too small again.

for now, I worked around it by hardcoding width that I like in
library/Grafana/ProvidedHook/Grapher.php:249

@cadirol
Copy link

cadirol commented Dec 10, 2021

@roman-rs
Thank you very much for your workaround!
The change in Grapher.php works, but yes, can't be the final solution

@kordickf
Copy link

kordickf commented Mar 1, 2023

Hi there, here is the solution to your problem - so you can change the width of your grafana graph embedded in icinga:
#307

It also isn't hardcoded, width can be changed as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants