Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifiers starting with underscores are reserved by C++ standard #57

Open
yeputons opened this issue Nov 13, 2016 · 0 comments
Open

Comments

@yeputons
Copy link
Contributor

See this for clarification. Strictly speaking, declaring a reserved identifier is undefined behavior, which means that as long as testlib does that, all checkers and validators have undefined behavior as well. I have not seen any problems with this in the wild so far (except for the famous), but the problem is here.

Some examples from testlib's code: _ok, _wa, __testlib_max.
I believe that the correct way of resolving this is to add a special namespace testlib and add a bunch of #defines to preserve backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant