Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom collector to correctly track metrics #144

Open
adyanth opened this issue Apr 15, 2022 · 2 comments · May be fixed by #176
Open

Use custom collector to correctly track metrics #144

adyanth opened this issue Apr 15, 2022 · 2 comments · May be fixed by #176
Labels
enhancement New feature or request

Comments

@adyanth
Copy link
Contributor

adyanth commented Apr 15, 2022

When caching metrics, all the labels from all the previous runs get cached which should not be the case. When a new run happens, the labels should be cleaned up and refreshed.

https://github.com/prometheus/client_python#custom-collectors
@MiguelNdeCarvalho
Copy link
Owner

I will take a look on this, that was definitely a big problem when I added the labels that's why I removed them!

@MiguelNdeCarvalho MiguelNdeCarvalho mentioned this issue Sep 11, 2022
Open
@MiguelNdeCarvalho MiguelNdeCarvalho added the enhancement New feature or request label Sep 11, 2022
@jkoelker
Copy link

jkoelker commented Nov 9, 2022

I have a POC branch at https://github.com/jkoelker/speedtest-exporter/tree/custom_collector. I'm currently running this caching for 900s and scraping every 1m. Here is the dashboard I'm using with it if anyone wants to try it if its working as they expect.

image

@jkoelker jkoelker linked a pull request Nov 19, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RFC: Rewrite with custom collector jkoelker/speedtest-exporter
3 participants
@jkoelker @adyanth @MiguelNdeCarvalho