-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Ambiguity on WebView2 HostObjectAsyncProxyBase Documentation #2751
Comments
Alright a couple more:
So just typographical errors, the only one leading to an actual conflict is the question of whether the asynchronous proxy methods which operate on the local object are also async or not (given they're local objects, one would assume not, but the Returns section does mention "promise" so I want to be sure.) |
Oh, that's interesting. Thank you for filing. I agree that these descriptions are confusing. Let me make sure that this issue is tracked on our backlog, and we'll get to it as soon as possible. |
Thanks for reporting these issues! Seems like we have several "copy/paste" style errors =)
Yes like you say, that is not a
Yes same issue. It should be
Good point - will fix thanks
We'll fix this as well.
Yes we'll fix that thanks. |
Much appreciated! Hope I'm not being to nitpicky by the way, the types thing makes sense in context, but I could also see someone trying to wrap those in promises anyway just to be consistent. The joys of architecting an interface am I right? |
Hello, I've been reviewing the WebView2 JavaScript interface documentation as I prepare a set of TypeScript interfaces for a project I'm working on and I noticed a few problems with the HostObjectAsyncProxyBase page:
The last one is minor but the first two have me wondering whether I should stick "any" or "Promise" on my interfaces.
I'm going through and modelling the whole JavaScript interface so if I find any other similar problems I'll add them to this ticket.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
AB#45821088
The text was updated successfully, but these errors were encountered: