Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing code examples: CircuitBreakerStateStoreFactory ... #1722

Closed
IjsConsulting opened this issue Aug 20, 2019 — with docs.microsoft.com · 6 comments
Closed

Missing code examples: CircuitBreakerStateStoreFactory ... #1722

IjsConsulting opened this issue Aug 20, 2019 — with docs.microsoft.com · 6 comments
Labels
architecture-center/svc assigned-to-author CXP assigned issue to author cloud-fundamentals/subsvc doc-enhancement Suggested additions/improvements to an article; user is not blocked Pri1 triaged

Comments

Copy link

The code provided does cover the whole solution, I'd like to see either the code for CircuitBreakerStateStoreFactory and ICircuitBreakerStateStore concrete class implementation, or a link to get the full solution. Without this, the example above makes partial sense. Also the variable, OpenToHalfOpenWaitTime , hasn't been defined in the CircuitBreaker class .. are we to guess what this?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@KetanChawda-MSFT KetanChawda-MSFT added assigned-to-author CXP assigned issue to author triaged doc-enhancement Suggested additions/improvements to an article; user is not blocked labels Aug 20, 2019
@KetanChawda-MSFT
Copy link

@IjsConsulting Thank you for your feedback! We will review and provide an update as appropriate.

@doodlemania2
Copy link
Contributor

We've taken this item to our internal backlog for further research and will update as necessary!

Copy link

What "further research" is necessary? Either you have the code available or you don't.

It is disappointing that the example is not fully baked.

@guojianwei001
Copy link

When do you finish "further research"?

@ckittel
Copy link
Member

ckittel commented Aug 10, 2020

Hey there @guojianwei001, @div78641, and @IjsConsulting,

We do not have an implementation of this at this time; the article is stand alone. The code illustrated can be used as part of your implementation of this cloud pattern. I'm sure this isn't the news you were looking for; however, not all is lost. One of our awesome apps consultants, @mleziva, has taken this exact article and put together a sample implementation using .net core for customers to reference. You can even see it running in action at http://cloudpatterns.austinmleziva.com/circuit-breaker.

Hopefully this helps you along on your journey.

@guojianwei001
Copy link

Hey @ckittel,
Cool! Thanks so much for your information. I didn't expect a reply that time. I had to search it everywhere, finnally I got one java version
I believe your reply will help more people. If possible, could we add the full code sample link at the bottom of this article?
So thank you once again.

SyntaxC4 pushed a commit that referenced this issue Sep 4, 2020
Confirm merge from repo_sync_working_branch to master to sync with https://github.com/microsoftdocs/architecture-center (branch master)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture-center/svc assigned-to-author CXP assigned issue to author cloud-fundamentals/subsvc doc-enhancement Suggested additions/improvements to an article; user is not blocked Pri1 triaged
Projects
None yet
Development

No branches or pull requests

8 participants