Implement conditional function breakpoints

[edumunoz]

• VSCode Version: 1.3.0
• OS Version: All

The debugging protocol for VSCode supports conditional function breakpoints.

However, I don't see how this can be achieved through the VSCode UI, since adding a condition is done through the glyph in the editor, but function breakpoints don't have a glyph:

A solution to match the current experience for line breakpoints would be to implement #7262.

Is there a reason why there is no action to add a condition to a breakpoint from the Breakpoints panel?

@weinand @isidorn

[f111fei]

Right click on line number. Edit BreakPoint is conditional function breakpoints. this is similar to chrome

[weinand]

The '+' action adds function breakpoints:

[edumunoz]

@f111fei, function breakpoints don't show a glyph on the line number (and hence referencing issue #7262).

@weinand, how do you add a condition to function breakpoints? I don't see a way.

[weinand]

@edumunoz oh I see, the question was about how to add the 'condition' and not how to add the 'function breakpoint'. Sorry, I missed that.

[weinand]

@isidorn I don't see a reason why a context action 'Edit Condition' in the breakpoints view wouldn't work, right?

[isidorn]

The UI for editing breakpoints is bound to the editor, thus if a breakpoint is in file a.txt, then editing that breakpoint would open that file and show the breakpoint widget on top of the line where the breakpoint is. That is the reason why we did not include 'edit breakpoint' in the viewlet, but only in the editor.

The issue here is that function breakpoints are not tied to an editor or a line, so I am not sure where to show the breakpoint widget in that case. We could just show it on top of the active editor, though then it is not in pair with the regualr edit breakpoint experience.

Suggestions welcome

[weinand]

duplicate of #3646