Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The panel width gets stuck #67361

Closed
alexdima opened this issue Jan 29, 2019 · 1 comment
Closed

The panel width gets stuck #67361

alexdima opened this issue Jan 29, 2019 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
December/January ...

Comments

@alexdima
Copy link
Member

Issue Type: Bug
Testing #67309

zurich.txt

Run cat zurich.txt. Resize the terminal width a lot. Notice the panel gets stuck at a certain width:

image

ERR Cannot read property 'getWidth' of undefined: TypeError: Cannot read property 'getWidth' of undefined
    at Object.reflowLargerGetLinesToRemove (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/BufferReflow.js:38:53)
    at Buffer._reflowLarger (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/Buffer.js:174:39)
    at Buffer._reflow (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/Buffer.js:167:18)
    at Buffer.resize (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/Buffer.js:152:18)
    at BufferSet.resize (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/BufferSet.js:78:22)
    at Terminal.resize (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/Terminal.js:1096:22)
    at Terminal.resize (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-xterm/lib/public/Terminal.js:53:20)
    at D._resize (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3806:361)
    at D.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3805:503)
    at e.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3901:182)
    at Object.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:445:146)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:453:153
    at Array.forEach (<anonymous>)
    at t.layoutViews (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:453:124)
    at t.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:448:34)
    at e.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3899:847)
    at t.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3905:445)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5737:68
    at Array.forEach (<anonymous>)
    at t.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5737:39)
    at o.t.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5315:390)
    at o.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:5364:583)
    at t.layout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4934:960)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4927:643
    at e.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:312)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:399:491
    at e.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:81:312)
    at r (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:87:1001)

VS Code version: Code - Insiders 1.31.0-insider (acc7365, 2019-01-29T06:13:57.866Z)
OS version: Darwin x64 18.2.0
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Jan 31, 2019
@Tyriar Tyriar added this to the December/January 2019 milestone Jan 31, 2019
@Tyriar
Copy link
Member

Tyriar commented Jan 31, 2019

Should be fixed with fix in #67439, keeping as bug for verification

@Tyriar Tyriar closed this as completed Jan 31, 2019
@alexdima alexdima added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
2 participants
@Tyriar @alexdima