Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "#region/#endregion" folding support for sql scripts. #62604

Closed
wants to merge 1 commit into from

Conversation

daviduuang
Copy link

add "#region/#endregion" folding support for sql scripts.

add "#region/#endregion" folding support for sql scripts.
@daviduuang daviduuang changed the title Update extensions/sql/language-configuration.json Add "#region/#endregion" folding support for sql scripts. Nov 5, 2018
@kieferrm kieferrm requested a review from alexr00 November 6, 2018 00:52
@alexr00
Copy link
Member

alexr00 commented Nov 6, 2018

@davidwang88, thanks for the PR! We actually pull this grammar from https://github.com/Microsoft/vscode-mssql. If you make the PR there and the maintainers merge it then I can pull it into VS Code when I next update the language extensions. Otherwise the change will just overwritten when I update the grammar from https://github.com/Microsoft/vscode-mssql 😅

@alexr00 alexr00 closed this Nov 6, 2018
@daviduuang
Copy link
Author

@davidwang88, thanks for the PR! We actually pull this grammar from https://github.com/Microsoft/vscode-mssql. If you make the PR there and the maintainers merge it then I can pull it into VS Code when I next update the language extensions. Otherwise the change will just overwritten when I update the grammar from https://github.com/Microsoft/vscode-mssql 😅

Hi! I forked the "vscode-mssql" project, and checked the content of file "syntaxes\SQL.plist" in it.
Then I checked "resources\app\extensions\sql\package.json" in "vscode" project, and found it seems that the content of file "resources\app\extensions\sql\language-configuration.json" is built and edited by human being instead of generated by script.

In fact, The comment lines at the bottom of "resources\app\extensions\sql\language-configuration.json" reveals it had beed edited by developer.

// enhancedBrackets:[
// 	{ openTrigger: 'n', open: /begin$/i, closeComplete: 'end', matchCase: true },
// 	{ openTrigger: 'e', open: /case$/i, closeComplete: 'end', matchCase: true },
// 	{ openTrigger: 'n', open: /when$/i, closeComplete: 'then', matchCase: true }
// ],
// noindentBrackets: '()',

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants