New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.28 - Official dark mode support for macOS Mojave #60790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use hosted build agents for Linux builds
…rrency linux build: limit yarn child concurrency
Reverts #59089 After further discussions with the team, we decided that we should not ship a bundled toml grammar. There are two reasons for this: * For the best toml experiance, users should use one of the toml plugins from the marketplace as these provide intellisense and other advanced language features. We previously recommend these plugins when you opened a toml file. However if we ship a bundled toml grammar, these recommendations will no longer appear * Engineering maintance costs on our side. Updating the grammar, maintaining tests, and handling issues related to it are all extra work that has to be considered. For these reasons, we do not think it makes sense to include basic toml support
debug: restart shuold also resolve configuration by providers when changed
…n active event fixes #59835
only have the n second timeout for prelaunch tasks that do not send active
Apply selection even when the items don't change
…e prelaunch tasks fixes #60593
debug: on restart, make sure to first disconnect and only then run th…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know VsCode has a dark mode in editor preferences, but i noticed color is not the same as macOS Mojave color in dark mode.
Maybe can we add this "important" :) feature in the next release?