Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.28 - Official dark mode support for macOS Mojave #60790

Closed
wants to merge 23 commits into from

Conversation

lewixlabs
Copy link

I know VsCode has a dark mode in editor preferences, but i noticed color is not the same as macOS Mojave color in dark mode.
Maybe can we add this "important" :) feature in the next release?

joaomoreno and others added 21 commits October 1, 2018 11:20
…rrency

linux build: limit yarn child concurrency
Reverts #59089

After further discussions with the team, we decided that we should not ship a bundled toml grammar. There are two reasons for this:

* For the best toml experiance, users should use one of the toml plugins from the marketplace as these provide intellisense and other advanced language features. We previously recommend these plugins when you opened a toml file. However if we ship a bundled toml grammar, these recommendations will no longer appear

* Engineering maintance costs on our side. Updating the grammar, maintaining tests, and handling issues related to it are all extra work that has to be considered.

For these reasons, we do not think it makes sense to include basic toml support
debug: restart shuold also resolve configuration by providers when changed
only have the n second timeout for prelaunch tasks that do not send active
Apply selection even when the items don't change
@msftclas
Copy link

msftclas commented Oct 12, 2018

CLA assistant check
All CLA requirements met.

debug: on restart, make sure to first disconnect and only then run th…
@lewixlabs lewixlabs closed this Oct 12, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet