Shortcut background broken with centered editor layout

[joaomoreno]

Steps:

1. Open new Window
2. Toggle Centered Editor layout
3. Resize the editor while holding Alt, so the other sash doesn't resize

[isidorn]

The issue here is that the watermark-box element is not belonging to the editor-area split view, thus it does not get centered.
IMHO it should be creataed inside the editor area split view just like the background image is.
forwarding to @chrmarti

[joaomoreno]

Just came here to file this issue once again. 😆

[isidorn]

Would be cool if we fix this. Workaround:

	"workbench.tips.enabled": false

[timfenney]

What are the steps to reproduce? I opened a split view editor, and even on a 4k monitor with low scaling couldn't repro it.

[joaomoreno]

Added steps to first comment. 👌

[LSViana]

@joaomoreno I'm trying to start contributing and I noticed this could be a possible first issue to solve. After a few hours, I did solve the issue and the solution is working consistently, but I'm pretty sure it's not optimal (and it doesn't have tests 😅).

Is it okay if I submit a PR for this to get some feedback and try polishing it?

[JacksonKearl]

@LSViana yes feel free to submit a PR and we can take it from there

[LSViana]

@JacksonKearl Thanks for your prompt response!

I just submitted #149132 and I need help because I have little (to no) knowledge about the VS Code codebase.

[p4nu]

If it's okay to @LSViana I could take a look at this

[p4nu]

Do we want a css change or should we move the creation of watermark to editor area split view?

I have found the place where the background is created but I need to figure out how to move the creation of watermark there. Any examples in the codebase would be appreciated!

[joaomoreno]

Simple CSS should do here.

[p4nu]

The position and width elements are not going to be connected between watermark-box and editor-group-letterpress. I'm not sure how the css can be implemented here because they are in different places in the dom hierarchy. The watermark-box is not getting any information from separator-borders.

[p4nu]