Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode of Chinese input method (IME) #59433

Closed
HaloWang opened this issue Sep 26, 2018 · 4 comments
Closed

Dark mode of Chinese input method (IME) #59433

HaloWang opened this issue Sep 26, 2018 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded
Milestone
October 2018

Comments

@HaloWang
Copy link

  • VSCode Version: 1.27.2 (1.27.2) / Version 1.28.0-insider (1.28.0-insider)
  • OS Version: macOS Mojave 10.14(18A391)
  • macOS system preferences: dark appearance

Steps to Reproduce:

  1. Open vscode, set the color theme to Dark+
  2. Switch input method to Pinyin - Simplified
  3. Type any words
  4. The appearance of input method this light mode, but I expect dark mode.

screen shot 2018-09-26 at 1 49 16 pm

Does this issue occur when all extensions are disabled?: For 1.28.0-insider, No.
@vscodebot vscodebot bot added the insiders label Sep 26, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 26, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@HaloWang
Copy link
Author

screen shot 2018-09-26 at 1 54 25 pm

This is what I can see in Xcode

@bpasero bpasero self-assigned this Sep 26, 2018
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron mojave VS Code on OS X Mojave issues labels Sep 26, 2018
@HaloWang HaloWang changed the title Dark mode of Chinese input method Dark mode of Chinese input method (IME) Sep 26, 2018
@HaloWang
Copy link
Author

electron/issues/13164
This commit solve my problem😂

@bpasero
Copy link
Member

bpasero commented Oct 1, 2018

Via #59742

@bpasero bpasero closed this as completed Oct 1, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed electron Issues and items related to Electron insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Oct 1, 2018
@bpasero bpasero added this to the October 2018 milestone Oct 1, 2018
@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
3 participants
@bpasero @HaloWang @mjbvz