[folding] navigateToLastEditLocation doesn't expand folded regions

[miguelsolorio]

Issue Type: Bug

Testing #59243

This works on a single file, however when you navigate to another file it doesn't expand folded regions.

Steps to reproduce

1. Make an edit to a line
2. Navigate to another tab
3. Use the shortcut command to navigate to last edit location (cmd+k cmd+q)
4. Line returns to last line in folder region (doesn't go to last edit location)

Expected results

1. Line to expand folded regions and return to previous position

VS Code version: Code - Insiders 1.28.0-insider (fe8d9d2, 2018-09-25T07:29:33.175Z)
OS version: Darwin x64 18.0.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	4, 4, 4
Memory (System)	16.00GB (0.04GB free)
Process Argv
Screen Reader	no
VM	22%

Extensions (8)

Extension	Author (truncated)	Version
vscode-svgviewer	css	1.4.6
gitlens	eam	8.5.6
vscode-pull-request-github	Git	0.1.6
beautify	Hoo	1.4.4
vscode-colorize	kam	0.7.2
theme-monokai-pro-vscode	mon	1.1.8
ayu	tea	0.16.0
sort-lines	Tyr	1.7.0

(9 theme extensions excluded)

[bpasero]

@rebornix looks like an issue with the editor to me. I am calling editor.setSelection() but the folded region is not expanded. This is possibly a race condition because the editor is not yet rendered when calling the method?

[rebornix]

@bpasero we get the folding model asynchronously so the folding regions are restored after the selection is set. The sequence of navigating to an invisible editor and setting selections is

• File open
• Restore view state --- > Folding.restoreViewState
• editor.setSelection()
• Folding.restoreViewState -> this.getFoldingModel().then( foldingModel.applyMemento )

It behaves differently when the target editor is already visible as there will be no restoreViewState.