Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Pick placeholder and content text does not meet color contrast ratio #51831

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 14, 2018 · 2 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues themes Color theme issues windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10

Additional Details:
ColorContrast,MAS1.4.3

Repro Steps:

  1. Launch VS Code.
  2. Navigate to Settings icon in Activity Bar->Press Enter->Select "File Icon Theme" from dropdown.
  3. Open color contrast analyzer and check the ratio.

Actual:
Color contrast ratio is less than 4.5:1 for the placeholder and the list items present on the screen

Expected:
Color Contrast ratio should not be less than 4.5:1.
Same issue observed on other color theme also.

Recommendations:
Refer below link which is repository of bug fixes code snippets:
[https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

](url)

User Impact:
The user will not be able to see the controls.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}

Attachment for Reference:

accessibility a11y_vscode_fileicontheme_colorcontrast

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the themes Color theme issues label Jun 14, 2018
@Tyriar Tyriar added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 14, 2018
@aeschli aeschli assigned miguelsolorio and unassigned aeschli Jun 15, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_FileIconTheme_ColorContrast:Color contrast ratio is less than 4.5:1 for the placeholder and the list items present on the screen [Accessibility]Quick Pick contrast ratio is less than 4.5:1 for the placeholder and the items Jul 3, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 3, 2018

This feels like law hanguing fruit. Assigning to July and also to @chrmarti to give code pointer to @misolori

@isidorn isidorn changed the title [Accessibility]Quick Pick contrast ratio is less than 4.5:1 for the placeholder and the items Quick Pick contrast ratio is less than 4.5:1 for the placeholder and the items Jul 3, 2018
@miguelsolorio miguelsolorio changed the title Quick Pick contrast ratio is less than 4.5:1 for the placeholder and the items Quick Pick placeholder and content text does not meet color contrast ratio Jul 3, 2018
@miguelsolorio miguelsolorio added this to the July 2018 milestone Jul 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 10, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues themes Color theme issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

6 participants