Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 2.0.x : extreme blur around the entire application (Windows 10) #51789

Closed
MeikTranel opened this issue Jun 13, 2018 · 93 comments
Closed
Assignees
Labels
electron Issues and items related to Electron font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@MeikTranel
Copy link

Issue Type: Bug

All views and their text is super blurred to the point that it makes things mostly unusable.

VS Code version: Code - Insiders 1.25.0-insider (583f1e4, 2018-06-13T05:18:10.709Z)
OS version: Windows_NT x64 10.0.17686

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 31.94GB (25.85GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe D:\Development\Schule\Testing
Screen Reader no
VM 0%
Extensions (27)
Extension Author (truncated) Version
yaml ada 0.0.9
cake-vscode cak 0.10.1
path-intellisense chr 1.4.2
vscode-markdownlint Dav 0.18.0
vscode-eslint dba 1.4.12
docs-authoring-pack doc 0.0.3
docs-markdown doc 0.0.3
xml Dot 2.3.0
gitlens eam 8.3.5
tslint eg2 1.0.30
beautify Hoo 1.3.2
rest-client hum 0.18.4
theme-monokai-pro-vscode mon 1.1.8
DocFX ms- 0.1.3
csharp ms- 1.15.2
PowerShell ms- 1.7.0
debugger-for-chrome msj 4.6.0
gradle-language nac 0.2.3
chef Pen 0.7.0
vscode-docker Pet 0.0.27
java red 0.26.0
vscode-icons rob 7.23.0
msbuild-project-tools tin 0.2.38
vscode-java-debug vsc 0.9.0
vscode-java-pack vsc 0.3.0
vscode-java-test vsc 0.6.1
vscode-maven vsc 0.9.0
@vscodebot
Copy link

vscodebot bot commented Jun 13, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jun 13, 2018
@MeikTranel
Copy link
Author

MeikTranel commented Jun 13, 2018

Here are some examples:

CloseUp

I installed a regular code instance in parallel to show a comparison.

Entire APP

@MeikTranel
Copy link
Author

The granular image is from the GIF converter. The blur itself is the real image i see in front of me.

@Tyriar Tyriar added electron Issues and items related to Electron and removed terminal Integrated terminal issues labels Jun 14, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2018

@MeikTranel do you have window.zoomLevel in your settings.json?

@bpasero bpasero added electron-update font-rendering Font rendering issues labels Jun 14, 2018
@bpasero bpasero changed the title Extreme Blur across entire app since 0.25.0-insider Extreme Blur across entire app since 1.25.0-insider Jun 14, 2018
@bpasero
Copy link
Member

bpasero commented Jun 14, 2018

This seems to be like a nightly Windows 10 build if I am not mistaken (https://changewindows.org/build/17686/pc) so maybe this should also get reported to Windows team. Does it reproduce with Chrome too?

@MeikTranel
Copy link
Author

No. Havent seen this within chrome, yet.
What makes me think it's a vscode thing is that it's not happening at all in 0.24.0 (that's why i showed the non-insider version in the screencap too)

@bpasero
Copy link
Member

bpasero commented Jun 15, 2018

@MeikTranel @Mehgugs can you try out a bare Electron application to see if you see the blurriness too. Just download and run: https://github.com/electron/electron/releases/download/v2.0.2/electron-v2.0.2-win32-x64.zip

@bpasero
Copy link
Member

bpasero commented Jun 15, 2018

@MeikTranel @Mehgugs also if you are up for a little experiment:

  • quit any running VSCode Insiders
  • open C:\Program Files\Microsoft VS Code Insiders\resources\app\out\main.js
  • find the place where it reads app.commandLine.appendSwitch("disable-mojo-local-storage");
    right after paste this: app.commandLine.appendSwitch('force-color-profile', 'srgb');
  • save (you will need to save as admin I guess)
  • start VSCode Insiders again
    => does the issue still reproduce?

@MeikTranel
Copy link
Author

@bpasero from what i'm seeing electron itself doesn't show any symptoms (the bare electron client really doesn't have that much to test with tho)

Checking out the other thing now.

BTW.: I updated to 17692 yesterday from 17686, so that i can play csgo again 😄 https://changewindows.org/build/redstone5/17692/pc
Issue is persisting through

@bpasero
Copy link
Member

bpasero commented Jun 15, 2018

@MeikTranel thanks. to test another application that is similar to VS Code and uses the same Electron version, can you try with Atom beta too: https://atom.io/beta

@MeikTranel
Copy link
Author

I tested the electron srgb command line switch; Didn't help -___-
At first i thought it did but when i moved the window around it started right back again :/

@MeikTranel
Copy link
Author

MeikTranel commented Jun 15, 2018

Oh hell yeah, progress! Atom has the same issue @bpasero
gif2
[Weird colors is the GifCam Compression, don't worry about those]
Do both use Electron 2.0 ?

@bpasero
Copy link
Member

bpasero commented Jun 15, 2018

@MeikTranel good to know 👍. does it reproduce if you run code-insiders --disable-gpu

Do both use Electron 2.0 ?

Yes

@MeikTranel
Copy link
Author

--disable-gpu seems to mitigate it.
i assume this disables hardware acceleration?

@bpasero
Copy link
Member

bpasero commented Jun 15, 2018

@MeikTranel yes it does. What kind of GPU are you running with?

@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2018

@MeikTranel yes. From your original report this is what GPU features were enabled:

2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled

So one of these must be to blame.

@MeikTranel
Copy link
Author

@bpasero this machine runs a GTX1080 and a 6700k (which comes integrated with a Intel® HD Graphics 530)

@MeikTranel
Copy link
Author

It's running on the GTX 1080 tho
image

@bpasero
Copy link
Member

bpasero commented Jun 15, 2018

@MeikTranel does it reproduce when no editor is opened and maybe only the explorer?

Also, can you share your settings file with us?

@MeikTranel
Copy link
Author

User Settings
{
    "workbench.iconTheme": "vscode-icons",
    "msbuildProjectTools": {
        "logging": {
            "level": "Information",
            "seq": {},
            "file": "",
            "trace": false
        },
        "language": {
            "disableFeature": {},
            "useClassicProvider": false,
            "disable": {
                "hover": false
            }
        },
        "nuget": {
            "newestVersionsFirst": true,
            "includePreRelease": true,
            "disablePrefetch": false
        },
        "schemaVersion": 1
    },
    "java.errors.incompleteClasspath.severity": "ignore",
    "rest-client.enableTelemetry": false,
    "rest-client.followredirect": false,
    "rest-client.includeAdditionalInfoInResponse": true,
    "gitlens.keymap": "none",
    "gitlens.advanced.messages": {
        "suppressShowKeyBindingsNotice": true
    }
}
Workspace Settings (although irrelevant considering this isn't a workspace specific issue)
{
    "files.exclude": {
        "**/.git": true,
        "**/.svn": true,
        "**/.hg": true,
        "**/CVS": true,
        "**/.DS_Store": true,
        "**/bin": true,
        "**/obj": true
    }
}

@MeikTranel
Copy link
Author

@bpasero by explorer you mean the vscode explorer? as in no code file open?

As for the other question: I tested and reproduced it specifically without chrome or other apps related also with only vscode running.

@DanaMW
Copy link

DanaMW commented Aug 27, 2018

Tried it, the terminal doesn't work the language would not load ,,, gave up on that idea...

@jonlepage
Copy link

oh yes , it's true, am lucky , i don't use vscode terminal in my projet.
I also notice vscode seem run little slow down.
but it ok for temp fix, it allow me to work.
Waiting vscode team publish a update.

@xLobito
Copy link

xLobito commented Aug 27, 2018

Just to notify. Visual Studio Live Share gets damaged if you change the compatibility mode.

Besides, the issue is not triggered while coding or edit some settings/preferences. But, if you use continously the extension block (To install something), then the blurry appears.

In the meantime, to avoid everything you should open vscode with gpu acceleration disabled.

@DanaMW
Copy link

DanaMW commented Aug 28, 2018

In my case it is blurry while in the editor only when the mouse is in the panel ON the text is it not. And GPU disabled does not work completely. Unless something else is going on here, after a time it begins to blur again for me

@jonlepage
Copy link

jonlepage commented Aug 29, 2018

ok i found another way and work for me.
Disable this %#$%^ FXAA.
Work for me.
BEFORE
image

AFTER FIX
image

So for nvidia user and also amd but you need search how , add vscode.exe in the custom manager mode , and force disable FXAA for this app.
Also play around other features if not work.
Am happy now and you can keep gpu acceleration.

Also i notice it happen sometime on slack and github desktop, so you can do same thing here for those.

@Lumenade
Copy link

Lumenade commented Aug 29, 2018

@djmisterjon Disabling FXAA worked for me, thank you. Make sure to set it for the right version, user vs system-wide (or both).
image 2
Also, for me it didn't start getting blurry until there was an overlay, like a message or the command pallette.

@MeikTranel
Copy link
Author

I will try to confirm this on my machine later today and then update the electron issue if this proves to be related.
This should not be regarded as fixed though. Force disabling FXAA for certain apps isn't really handy in all situations.

@jonlepage
Copy link

jonlepage commented Aug 29, 2018

this seem a issue for many engine with shadder.
http://pixijs.download/dev/docs/PIXI.filters.FXAAFilter.html

image

@DanaMW
Copy link

DanaMW commented Aug 29, 2018

After an hour of testing @djmisterjon 's fix is the most effective. It appears to have worked here (so far) thank you.
Note: On nvida card Control panel, Manage 3D settings ,Adding Code.exe Turning FXAA Off for code.

@ripvannwinkler
Copy link

For me at least, the FXAA fix doesn't work. See screenshot:
2018-08-29 16_46_33-form tsx - client - visual studio code

@Arcanemagus
Copy link

@ripvannwinkler It looks like you set the global setting, try adding settings for code.exe explicitly as specified in the other comments.

@ripvannwinkler
Copy link

It doesn't matter. Off is off, whether it's for one app or the whole system.

@jonlepage
Copy link

jonlepage commented Aug 30, 2018

@ripvannwinkler
Don't forget to click on APPLY, the button are hidden bottom Right of the window panel.
Also reboot vscode after apply setting.
I dont test with global parameter! , so i don't know if nvidia know the vscode app and able to force change the native anti-aliasing setting of the app.

Also try to disable or play with other anti-aliasing setting if this dont help you.

@MeikTranel
Copy link
Author

I can verify that 2 options for temporarily resolving the issue at hand:

2018-08-30_18-55-30

  1. Set compatibility to Vista - resolved the issue at hand but seems to be draining the performance
  2. Disable FXAA for code - resolved it for me without visible performance issues:
    a. Make sure to quit all vscode instances before checking if it works.

I will pass this onto the guys at electron in electron/electron#13646

@ripvannwinkler
Copy link

ripvannwinkler commented Aug 30, 2018

I did end up disabling FXAA for VS Code specifically as opposed to the global setting and have not seen any blurry text since (4+ hours of coding since last reported). It appears disabling FXAA for VS Code specifically is in fact a workable solution.

@TheMasterFX
Copy link

I just realized that if I start VS Code via Command line (cmd => code) I don't have this problem at all. When I start VS Code via shortcut in the Start Menu it is back again. What I also noticed is, that when I start via cmd the NVidia Experience Overlay Popup on the top right appears, which indicates that Nvidia recognized this application to be GPU accelerated. This doesn't happen when I start VS Code via start menu.

And then I noticed, that I have two installations of VS-Code. One User one System. When I enter "code" in the command line the "system installation" is started, from the start menu the user installation is started.
So I uninstalled the user installation and now everthing is fine now!

@gabaruga
Copy link

Can confirm as of VS Code 1.30.1, Win 10.0.17763 and GeForce 960 with the latest drivers:
Disabling FXAA for VS Code specifically resolves blurrines on losing focus or context menus opening.

@why-does-ie-still-exist
Copy link

Got a new laptop with a 1060 and intel integrated graphics, and the blurriness happened to me too. It's not vs code, because the blurriness also happens on edex-ui, another electron project. However, after reading this thread, I turned off FXAA like @gabaruga did in Nvidia Control panel, and now both edex-ui and vs code work perfectly.

Help info:

Version: 1.30.1 (user setup)
Commit: dea8705087adb1b5e5ae1d9123278e178656186a
Date: 2018-12-18T18:12:07.165Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17763

@Mrdapeng
Copy link

if you are run vs-code on mac-os, please run npm install electron -g ,it will solve your problem

@bpasero
Copy link
Member

bpasero commented Jan 25, 2019

Closing this issue given that we plan to release VSCode stable early February with Electron 3.x. If you want to benefit from the fix already, consider to use our insiders version that already contains the fix: https://code.visualstudio.com/insiders/

@bpasero bpasero closed this as completed Jan 25, 2019
@bpasero bpasero added this to the December/January 2019 milestone Jan 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron font-rendering Font rendering issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests