Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] When exiting High Contrast, restore previous color theme #46862

Closed
furgat opened this issue Mar 28, 2018 · 3 comments
Closed

[themes] When exiting High Contrast, restore previous color theme #46862

furgat opened this issue Mar 28, 2018 · 3 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@furgat
Copy link

furgat commented Mar 28, 2018

  • VSCode Version: 1.21.1
  • OS Version: Windows 10 - Version 1709 - Build 16299.309

Steps to Reproduce:

  1. Open VS Code and select a custom color theme
  2. Activate High Contrast ( I used Shift + Alt + PrintScn )
  3. Observe VS Code has changed to High Contrast color theme
  4. Deactivate High Contrast ( I used Shift + Alt + PrintScn )
  5. Observe VS Code now shows the default color theme instead of the selected color theme
    5a. Restarting VS Code will restore it to the selected color theme

Does this issue occur when all extensions are disabled?: No. With extensions disabled, VS Code switches from the default color theme to high contrast, and back to default color theme. This issue only occurs with a custom color theme selected.

It appears as though VS Code only reverts to the default color theme when leaving High Contrast, rather than to the user selected color theme. I'd expect it to revert to the color theme I chose.

@vscodebot vscodebot bot added the themes Color theme issues label Mar 28, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 29, 2018

The previous theme is not remembered and what you see is the expected result.
Question: Is that a common workflow?

@aeschli aeschli changed the title When exiting High Contrast, selected color theme is not restored [themes] When exiting High Contrast, restore previous color theme Mar 29, 2018
@aeschli aeschli added the feature-request Request for new features or functionality label Mar 29, 2018
@aeschli aeschli added this to the Backlog milestone Mar 29, 2018
@furgat
Copy link
Author

furgat commented Apr 4, 2018

It is pretty common for me as a Front-End developer. My job includes ensuring new pages/elements/styles are accessible, part of which is High Contrast testing, so I activate and deactivate HC multiple times a day typically.

@aeschli aeschli modified the milestones: Backlog, August 2018 Aug 10, 2018
@aeschli aeschli added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues verification-needed Verification of issue is requested labels Aug 10, 2018
@roblourens roblourens added the verified Verification succeeded label Aug 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants