Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't detect git repository by opening a symlink to a file within it #45919

Closed
phosphoer opened this issue Mar 15, 2018 · 4 comments
Closed

Can't detect git repository by opening a symlink to a file within it #45919

phosphoer opened this issue Mar 15, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) git GIT issues
Milestone

Comments

@phosphoer
Copy link

phosphoer commented Mar 15, 2018

Our Unity project utilizes symlinks which point to folders within submodules in order to avoid having extra source code in the Unity Assets folder. Now that submodules are no longer all automatically loaded, we are seeing an issue where opening a file within a submodule through the symlink does not trigger the submodule to be loaded.

  • VSCode Version: 1.21.1
  • OS Version: Windows 10 Insiders

Steps to Reproduce:

  • Create a symlink somewhere in your project which points to a folder within a submodule.
  • Press Ctrl-P and enter the name of a file within the submodule, observe two entries are listed, the path directly within the submodule, and the path through the symlink.
  • Open the path through the symlink, and observe that the relevant submodule is not loaded into the source control provider list.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Mar 15, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@joaomoreno
Copy link
Member

This is probably not related to submodules but to symlinks to files within git repositories. I doubt the repository would get detected.

@joaomoreno joaomoreno changed the title Symlinks mess up auto-opening of submodule Can't detect git repository by opening a symlink to a file within it Mar 19, 2018
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Mar 19, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Mar 19, 2018
@joaomoreno
Copy link
Member

/duplicate #5970

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 18, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 18, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) git GIT issues
Projects
None yet
Development

No branches or pull requests

2 participants