Tasks: npm script aren't being prefixed with "run"

[bruno-brant]

• VSCode Version: 1.22.0-insider 1126701 x64
• OS Version: Microsoft Windows [Version 10.0.17074.1002]

Steps to Reproduce:

1. Setup a task in tasks.json for "npm", with script as "build".
2. Run the task by calling npm: run build in the command bar.

Does this issue occur when all extensions are disabled?: Yes/No
Yes.

Example task.json:

{
	// See https://go.microsoft.com/fwlink/?LinkId=733558
	// for the documentation about the tasks.json format
	"version": "2.0.0",
	"tasks": [
		{
			"type": "npm",
			"script": "build",
			"group": {
				"kind": "build",
				"isDefault": true
			}
		}
	]
}

Task.json that works:

{
	// See https://go.microsoft.com/fwlink/?LinkId=733558
	// for the documentation about the tasks.json format
	"version": "2.0.0",
	"tasks": [
		{
			"type": "npm",
			"script": "run build", // <--- must add run!
			"group": {
				"kind": "build",
				"isDefault": true
			}
		}
	]
}

If this is expected behavior, it changed from last version. I think that the key "script" may lead a user (such as myself) to believe that a npm run-script will called, as opposed to any npm command (as it is right now).

Also, if that's expected behavior, task generation for npm is generating it wrong (exactly like my first example).

[bruno-brant]

I think my diagnose may be wrong. What is happening is that nothing is being ran.

I thought the reason was that vscode was shelling "npm build" instead of "npm run build".

As you can see from the image, nothing is ran. Typing npm run build in the command line (inside vscode) successfully builds the application.

[dbaeumer]

This is a duplicate of #45684. I broke that yesterday but is fixed in todays insider again. We added support for space quoting and I wrongly quoted whole command lines hence making them fail.