Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: add region folding to syntax folding #45118

Closed
aeschli opened this issue Mar 6, 2018 · 0 comments · Fixed by #55399
Closed

Markdown: add region folding to syntax folding #45118

aeschli opened this issue Mar 6, 2018 · 0 comments · Fixed by #55399
Assignees
Labels
help wanted Issues identified as good community contribution opportunities markdown Markdown support issues

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 6, 2018

#44795 adds language aware folding to markdown (Thanks a lot!)

Don't forget to also support the folding regions that we already support for markdown:

		"markers": {
			"start": "^\\s*<!--\\s*#?region\\b.*-->",
			"end": "^\\s*<!--\\s*#?endregion\\b.*-->"
		}

Ideally your scanner known where the comment tokens are and can do this more efficiently (and correct) that a regexp on every line.

@vscodebot vscodebot bot added the editor label Mar 6, 2018
@kieferrm kieferrm added markdown Markdown support issues and removed editor labels Mar 7, 2018
@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Jun 27, 2018
@JacksonKearl JacksonKearl self-assigned this Jul 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues identified as good community contribution opportunities markdown Markdown support issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants